Skip to content

chore: Add visual tests for more components (D-L) - #4852

Merged
jperals merged 28 commits into
mainfrom
dev-v3-jotresse-test-definitions-05
Sep 3, 2026
Merged

chore: Add visual tests for more components (D-L)#4852
jperals merged 28 commits into
mainfrom
dev-v3-jotresse-test-definitions-05

Conversation

@jperals

@jperals jperals commented Jul 31, 2026

Copy link
Copy Markdown
Member

Description

Ticket: D417180663

How has this been tested?

Manually compared Allure report output against internal one for each component

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals jperals changed the title Dev v3 jotresse test definitions 05 chore: Add visual tests for more components (C-I) Jul 31, 2026
@jperals jperals changed the title chore: Add visual tests for more components (C-I) chore: Add visual tests for more components (D-R) Jul 31, 2026
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (6ecc94b) to head (8826434).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4852   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         959      959           
  Lines       31342    31342           
  Branches    11578    11577    -1     
=======================================
  Hits        30610    30610           
- Misses        686      725   +39     
+ Partials       46        7   -39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds visual regression test definitions for components from Divider through RadioGroup.

Changes:

  • Adds 19 component visual test suites covering permutations, responsive layouts, and interactions.
  • Registers the suites in the central definitions index.
  • Requires Jest runner entrypoints and a HelpPanel focus setup fix.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Summary
test/definitions/visual/radio-group.ts Radio group visual scenarios
test/definitions/visual/progress-bar.ts Progress bar variants
test/definitions/visual/pagination.ts Pagination permutations
test/definitions/visual/link.ts Link permutations and styles
test/definitions/visual/input.ts Input permutations
test/definitions/visual/icon.ts Icon variants and sizing
test/definitions/visual/help-panel.ts Help panel scenarios; focus setup targets missing inputs and times out
test/definitions/visual/header.ts Responsive header scenarios
test/definitions/visual/grid.ts Responsive grid scenarios
test/definitions/visual/form.ts Form scenarios
test/definitions/visual/form-field.ts Responsive form-field scenarios
test/definitions/visual/flashbar.ts Flashbar scenarios
test/definitions/visual/flashbar-stacked.ts Stacked Flashbar scenarios
test/definitions/visual/file-upload.ts File upload permutations
test/definitions/visual/file-token-group.ts File token permutations
test/definitions/visual/file-input.ts File input scenario
test/definitions/visual/file-dropzone.ts File dropzone scenario
test/definitions/visual/error-boundary.ts Error boundary fallback states
test/definitions/visual/divider.ts Divider permutations
test/definitions/index.ts Central suite registration; Jest runner entrypoints are missing
Suppressed comments (2)

test/definitions/visual/help-panel.ts:23

  • focusInputs() waits for a visible native input before dispatching focus events, but this AppLayout page renders no input elements. The setup will therefore time out before the screenshot is captured; remove this setup or target an element that the page actually renders.
      setup: async ({ page }) => {
        await page.focusInputs();
      },

test/definitions/visual/help-panel.ts:31

  • focusInputs() waits for a visible native input before dispatching focus events, but this loading AppLayout page renders no input elements. The setup will therefore time out before the screenshot is captured; remove this setup or target an element that the page actually renders.
      setup: async ({ page }) => {
        await page.focusInputs();
      },

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/definitions/index.ts
Comment thread test/definitions/visual/help-panel.ts Outdated
Comment thread test/definitions/visual/line-chart.ts Outdated
await page.click(TEST_CHART_FILTER_TRIGGER);
await page.keys(['Escape']);
await page.focusNextElement();
await page.keys(['ArrowRight', 'ArrowDown', 'ArrowRight']);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this require rtl guard like the one above?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right —the original test did not have it, but I think it should. Same with some other tests, from here and from bar chart, which I just updated accordingly in the last commit.

@jperals
jperals added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 2, 2026
@jperals
jperals added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 2, 2026
@jperals
jperals added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit c91603d Sep 3, 2026
66 checks passed
@jperals
jperals deleted the dev-v3-jotresse-test-definitions-05 branch September 3, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants