feat: Add info variant to Icon - #4946
Open
ywyyu17 wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4946 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 959 959
Lines 31342 31342
Branches 11578 11578
=======================================
Hits 30610 30610
Misses 686 686
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ywyyu17
requested review from
at-susie
and
a lite review from Copilot
and removed request for
Copilot
September 2, 2026 13:33
ywyyu17
marked this pull request as ready for review
September 2, 2026 13:36
at-susie
reviewed
Sep 2, 2026
| | 'subtle' | ||
| | 'success' | ||
| | 'warning' | ||
| | 'info'; |
Member
There was a problem hiding this comment.
Do you wanna add any example page for this new variant? Otherwise, we cannot screenshot-test this variant.
at-susie
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an info color variant to the Icon component, mapped to the existing
colorTextStatusInfodesign token.The change is additive and backward compatible. Nothing renders differently unless a consumer explicitly sets
variant="info", and thecolorTextStatusInfotoken is already defined in different themes, so there is no theme-specific work and no migration required.How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.