Skip to content

feat: Add info variant to Icon - #4946

Open
ywyyu17 wants to merge 5 commits into
mainfrom
dev-v3-ywy
Open

feat: Add info variant to Icon#4946
ywyyu17 wants to merge 5 commits into
mainfrom
dev-v3-ywy

Conversation

@ywyyu17

@ywyyu17 ywyyu17 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Description

Adds an info color variant to the Icon component, mapped to the existing colorTextStatusInfo design token.

The change is additive and backward compatible. Nothing renders differently unless a consumer explicitly sets variant="info", and the colorTextStatusInfo token is already defined in different themes, so there is no theme-specific work and no migration required.

How has this been tested?

  • Regenerated and verified the documenter API snapshot (single-line info addition).
  • Verified the change is backward compatible — existing variants render unchanged.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (3e7a10c) to head (8155182).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4946   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         959      959           
  Lines       31342    31342           
  Branches    11578    11578           
=======================================
  Hits        30610    30610           
  Misses        686      686           
  Partials       46       46           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ywyyu17
ywyyu17 requested review from at-susie and a lite review from Copilot and removed request for Copilot September 2, 2026 13:33
@ywyyu17
ywyyu17 marked this pull request as ready for review September 2, 2026 13:36
@ywyyu17
ywyyu17 requested a review from a team as a code owner September 2, 2026 13:36
Comment thread src/icon/interfaces.ts
| 'subtle'
| 'success'
| 'warning'
| 'info';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wanna add any example page for this new variant? Otherwise, we cannot screenshot-test this variant.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it, thank you so much @at-susie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants