Skip to content

fix: Stop importing the generated test-utils barrel from two wrappers #4949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gethinwebster merged 2 commits into from
Sep 3, 2026
+3 −5
Merged

fix: Stop importing the generated test-utils barrel from two wrappers #4949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99ec828
fix: Stop importing the generated test-utils barrel from two wrappers
TrevorBurnham Aug 30, 2026
e005fcd
Update linter to catch these issues
gethinwebster Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export default tsEslint.config(
'error',
[
{
pattern: './src/test-utils/dom/index.ts',
pattern: './src/test-utils/dom/index.*s',
message:
"Do not import from the augmented ElementWrapper barrel '{{ path }}'. Use @cloudscape-design/test-utils-core/dom instead.",
},
Expand Down
3 changes: 1 addition & 2 deletions src/test-utils/dom/button-group/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
import { ComponentWrapper, ElementWrapper } from '@cloudscape-design/test-utils-core/dom';
import { ComponentWrapper, createWrapper, ElementWrapper } from '@cloudscape-design/test-utils-core/dom';

import ButtonWrapper from '../button/index.js';
import ButtonDropdownWrapper from '../button-dropdown/index.js';
import FileInputWrapper from '../file-input/index.js';
import createWrapper from '../index.js';
import ToggleButtonWrapper from '../toggle-button/index.js';

import testUtilStyles from '../../../button-group/test-classes/styles.selectors.js';
Expand Down
3 changes: 1 addition & 2 deletions src/test-utils/dom/popover/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
import { ComponentWrapper, ElementWrapper } from '@cloudscape-design/test-utils-core/dom';
import { ComponentWrapper, createWrapper, ElementWrapper } from '@cloudscape-design/test-utils-core/dom';

import ButtonWrapper from '../button';
import createWrapper from '../index.js';

import styles from '../../../popover/styles.selectors.js';

Expand Down
Loading