Skip to content

chore: Replace one-theme’s side navigation icon - #4963

Merged
georgylobko merged 2 commits into
mainfrom
chore/side-nav-icon-in-onetheme
Sep 3, 2026
Merged

chore: Replace one-theme’s side navigation icon#4963
georgylobko merged 2 commits into
mainfrom
chore/side-nav-icon-in-onetheme

Conversation

@georgylobko

@georgylobko georgylobko commented Sep 2, 2026

Copy link
Copy Markdown
Member

Description

Replaced existing side navigation icon in AppLayout when one-theme is applied.

Screen.Recording.2026-09-02.at.2.01.56.PM.mov

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (dec0201) to head (903ff58).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4963   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         959      959           
  Lines       31342    31347    +5     
  Branches    11577    11579    +2     
=======================================
+ Hits        30611    30616    +5     
  Misses        724      724           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@georgylobko
georgylobko marked this pull request as ready for review September 2, 2026 12:39
@georgylobko
georgylobko requested a review from a team as a code owner September 2, 2026 12:39
@georgylobko
georgylobko requested review from taheramr and removed request for a team September 2, 2026 12:39
if (isMobile) {
return 'close';
}
if (isThemeActive(Theme.OneTheme)) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also make it only when collapsible={true} for now. This will help set expectations, and also improve consistency with the way other drawers behave, given that we aren't changing the icon for drawers that collapse fully.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@georgylobko
georgylobko added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit 85f92b8 Sep 3, 2026
65 checks passed
@georgylobko
georgylobko deleted the chore/side-nav-icon-in-onetheme branch September 3, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants