chore: Replace one-theme’s side navigation icon - #4963
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4963 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 959 959
Lines 31342 31347 +5
Branches 11577 11579 +2
=======================================
+ Hits 30611 30616 +5
Misses 724 724
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jkuelz
requested changes
Sep 2, 2026
| if (isMobile) { | ||
| return 'close'; | ||
| } | ||
| if (isThemeActive(Theme.OneTheme)) { |
Member
There was a problem hiding this comment.
Let's also make it only when collapsible={true} for now. This will help set expectations, and also improve consistency with the way other drawers behave, given that we aren't changing the icon for drawers that collapse fully.
georgylobko
force-pushed
the
chore/side-nav-icon-in-onetheme
branch
from
September 3, 2026 09:09
450182c to
903ff58
Compare
georgylobko
enabled auto-merge
September 3, 2026 09:10
jkuelz
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced existing side navigation icon in AppLayout when one-theme is applied.
Screen.Recording.2026-09-02.at.2.01.56.PM.mov
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.