[Spec 1280] Post-merge completion records: build-complete + thread FINAL + verify-approval - #1409
Open
waleedkadous wants to merge 3 commits into
Open
[Spec 1280] Post-merge completion records: build-complete + thread FINAL + verify-approval#1409waleedkadous wants to merge 3 commits into
waleedkadous wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships the completion records for Spec 1280 (prompt rewrite — implementation merged in PR #1362) from the stranded builder branch to main, per the #1345/#1376 records-PR pattern.
Carries (cherry-picked from
builder/1280-rewrite):e235ba45→chore(porch): 1280 implement build-complete5053f5cf→[Spec 1280] Thread: FINAL— builder thread narrative closing entry2c34337d→chore(porch): 1280 verify-approval gate-approved(human verify word 2026-08-09)Deliberately excluded:
50126695(chore(porch): 1280 implement phase-transition) — that commit is the porch state-machine loop filed as #1408 (porch verify-approval resets all plan phases to pending): it resets all 11 plan phases fromcompleteback topendingand would erase the completion record this PR exists to preserve.Consequence of the exclusion: status.yaml on main will show
build_complete: true+verify-approval: approvedbut no finalprotocol completeentry, because porch never emitted a valid one — that's blocked on the #1408 fix, not on this PR.🤖 Generated with Claude Code