Skip to content

fix: overlay cache config #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SoWieMarkus merged 2 commits into from
Sep 24, 2026
Merged

fix: overlay cache config #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d6d064
fix: overlay cache config
SoWieMarkus Sep 24, 2026
0098dcb
fix: enhance overlay cache logging for enabled/disabled states
SoWieMarkus Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/manager/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,9 +396,12 @@ func main() {
var cacheMonitor *cache.Monitor
var cacheWrapper *cache.Wrapper
if c := conf.GetConfigOrDie[cache.RootConfig](); c.Cache.Enabled {
setupLog.Info("overlay caching is enabled", "gvks", c.Cache.GVKs, "ttl", c.Cache.TTL)
cacheMonitor = cache.NewMonitor("cortex_")
cacheWrapper = cache.NewWrapper(mgr, c.Cache, cacheMonitor)
multiclusterClient.Wrappers = append(multiclusterClient.Wrappers, cacheWrapper)
} else {
setupLog.Info("overlay caching is disabled")
}
if err := multiclusterClient.InitFromConf(ctx, mgr, multiclusterClientConfig); err != nil {
setupLog.Error(err, "unable to initialize multicluster client")
Expand Down
12 changes: 6 additions & 6 deletions helm/bundles/cortex-nova/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,6 @@ kvm:
# skipped by the filter, even if they match one of the prefixes above.
ignoredDomainNames: []

# Cache configuration for the transparent in-process overlay cache.
cache:
enabled: true
gvks:
- cortex.cloud/v1alpha1/Reservation

cortex: &cortex
crd: {enable: false}
# Disable the default ServiceMonitor and metrics service from the kubebuilder stack.
Expand Down Expand Up @@ -139,6 +133,12 @@ cortex: &cortex
# ssoSecretRef:
# name: cortex-nova-openstack-sso
# namespace: default
# Cache configuration for the transparent in-process overlay cache.
cache:
enabled: true
gvks:
- cortex.cloud/v1alpha1/Reservation
- cortex.cloud/v1alpha1/CommittedResource
monitoring:
labels: &cortexMonitoringLabels
github_org: cobaltcore-dev
Expand Down
Loading