Skip to content

Migrate HypervisorOffboardingReconciler to SSA status updates - #341

Open
fwiesel wants to merge 1 commit into
mainfrom
ssa-offboarding
Open

fwiesel wants to merge 1 commit into
mainfrom
ssa-offboarding

Conversation

@fwiesel

@fwiesel fwiesel commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Replace PatchHypervisorStatusWithRetry with Status().Apply() for the ConditionTypeOffboarded condition. Seed only that condition so SSA does not claim ownership over conditions written by other controllers.

Depends on #335 (ssa-conditions-helpers).

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8569fbcf-9f2d-4d0b-8e3c-18deb95999c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ssa-offboarding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fwiesel

fwiesel commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@fwiesel
fwiesel force-pushed the ssa-conditions-helpers branch from 181d69b to 7d13627 Compare July 13, 2026 19:59
@fwiesel
fwiesel force-pushed the ssa-conditions-helpers branch from 7d13627 to dd0de9c Compare July 16, 2026 10:01
@fwiesel
fwiesel force-pushed the ssa-conditions-helpers branch from dd0de9c to 40e4306 Compare July 16, 2026 10:23
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 45 days with no activity.

@github-actions github-actions Bot added the stale label Aug 31, 2026
@fwiesel
fwiesel force-pushed the ssa-conditions-helpers branch from 40e4306 to 5125897 Compare September 17, 2026 12:29
@fwiesel
fwiesel force-pushed the ssa-offboarding branch 3 times, most recently from 0667f15 to d5f48f1 Compare September 17, 2026 12:54
@fwiesel
fwiesel force-pushed the ssa-conditions-helpers branch from 1e5f268 to b9f51ac Compare September 17, 2026 13:19
@fwiesel
fwiesel force-pushed the ssa-conditions-helpers branch from b9f51ac to 06083a9 Compare September 17, 2026 13:26
Base automatically changed from ssa-conditions-helpers to main September 21, 2026 07:28
Replace PatchHypervisorStatusWithRetry with Status().Apply() for the
ConditionTypeOffboarded condition. Seed only that condition so SSA
does not claim ownership over conditions written by other controllers.

Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 70.05% (+0.07%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/offboarding_controller.go 68.60% (+1.13%) 86 (+3) 59 (+3) 27 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant