Skip to content

fix(widgets): declare TextArea's inherited trim config unsupported #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mstijak merged 1 commit into from
Sep 1, 2026
Merged

fix(widgets): declare TextArea's inherited trim config unsupported #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions legacy/docs/content/widgets/configs/TextArea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export default {
showClear: false,
hideClear: false,
inputType: false,
trim: false,
reactOn: {
type: 'string',
description: <cx><Md>
Expand Down
8 changes: 7 additions & 1 deletion packages/cx/src/widgets/form/TextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ import { autoFocus } from "../autoFocus";
import { getActiveElement } from "../../util/getActiveElement";
import { NumberProp } from "../../ui/Prop";

export interface TextAreaConfig extends TextFieldConfig {
/**
* `trim` is intentionally omitted: `TextArea` renders its own input which commits the raw value,
* so leading and trailing whitespace is always preserved.
*/
export interface TextAreaConfig extends Omit<TextFieldConfig, "trim"> {
/** Specifies the number of visible lines. */
rows?: NumberProp;

Expand Down Expand Up @@ -65,6 +69,8 @@ export class TextArea extends TextField<TextAreaConfig> {

TextArea.prototype.baseClass = "textarea";
TextArea.prototype.reactOn = "blur";
// `trim` is not supported by TextArea, so a global `TextField.prototype.trim = true` must not leak into it.
TextArea.prototype.trim = false;
TextArea.prototype.suppressErrorsUntilVisited = true;

interface InputProps {
Expand Down
Loading