Repository navigation
ci: drop the npm publish step; releases are distributed via git - #52
Merged
Merged
Conversation
The publish step skipped npm publish with exit 0 when no token was set, so every release run showed a green publish that never happened. npm cannot be this package's channel (the unscoped name belongs to another project, and #42 made git the documented install path), so the step and the unused id-token permission are removed. The workflow still verifies the build, now fails when the release tag does not match package.json, and states the distribution in the job summary. Fixes #51
Owner
Author
|
Lead review: PASS. Drops the npm step + id-token/registry-url (least privilege), adds a fail-closed tag==package.json version check on release (tag passed via env, not interpolated into the script), and a job summary stating git distribution. CI green on da25820. Merging with the repo's admin bypass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51.
Publish to npmstep, whose skip with exit 0 made every release look like a green publish (v0.1.4: "NODE_AUTH_TOKEN is not configured; skipping npm publish."). Also removed areid-token: writeand theregistry-urlthat only the publish used.pi install git:github.com/code-yeongyu/pi-apply-patchthe documented install, which resolves the release tag.releaseevent, the run fails when the tag is notv<package.json version>. A mismatched tag is the one release mistake that would ship the wrong code through git installs.npm pack --dry-run).Verification
actionlintclean, and the YAML parses with exactly the expected steps andpermissions: {contents: read}.v0.1.3andv9.9.9against package.json 0.1.4 fail with the error annotation.v0.1.4is the matching case and passes the same comparison.[Unreleased]. The released[0.1.4]section is untouched.