Skip to content

chore(deps): require pi 0.83 runtime - #6

Closed
madgegja wants to merge 1 commit into
code-yeongyu:mainfrom
madgegja:senpi-remediation-20260801
Closed

madgegja wants to merge 1 commit into
code-yeongyu:mainfrom
madgegja:senpi-remediation-20260801

Conversation

@madgegja

@madgegja madgegja commented Aug 1, 2026

Copy link
Copy Markdown

Summary

  • require pi 0.83 peers and Node 22.19+
  • update CI to Node 22/24
  • refresh the lock while preserving jsdom, undici, readability, and turndown versions

Verification

  • npm run check
  • npm test (40)
  • npm ls --all
  • npm pack --dry-run
  • direct production audit: 0 vulnerabilities

@madgegja

madgegja commented Aug 2, 2026

Copy link
Copy Markdown
Author

All local gates pass. Please approve https://github.com/code-yeongyu/pi-webfetch/actions/runs/30711016262. The main-protection ruleset still requires Node 20/22 contexts while this PR intentionally emits Node 22/24; please update ruleset 15822204, then merge with a merge commit after CI is green.

@code-yeongyu code-yeongyu left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runtime bump is directionally right (Node 22.19, CI 22/24) but cannot land as-is.

Findings:

  • package.json:35-37 (peerDependencies): @earendil-works/pi-ai, @earendil-works/pi-coding-agent, and @earendil-works/pi-tui are pinned to ^0.83.0. Caret ranges reject downstream date-versioned runtimes (for example 2026.9.24). Peer range for @earendil-works/pi-* must be * (or >=0.87.0 if a 0.87 API is required). Never ^0.83 / ^0.87.
  • package.json:35-37: 0.83 is stale versus current upstream 0.87.1.
  • .github/workflows/ci.yml:26 (matrix.node): 22/24 is the right matrix, but the refresh also moves install/test to Bun 1.4.2 (oven-sh/setup-bun@v2, bun install --frozen-lockfile) plus an npm-consumer job. This PR only swaps the node versions.

Closing as superseded by the dependency refresh once that PR merges. The Node 22.19 engine bump will be included there with * peers.

@code-yeongyu

Copy link
Copy Markdown
Owner

Superseded by #10 (merged in 169155b), which includes the Node >=22.19.0 engine bump and the 22/24 CI matrix, plus Bun 1.4.2 and * peers for @earendil-works/pi-* (caret ^0.83.0 peers would reject date-versioned downstream runtimes).

@code-yeongyu

Copy link
Copy Markdown
Owner

Closed as superseded by #10 (merged in 169155b).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants