Repository navigation
Conversation
Author
|
All local gates pass. Please approve https://github.com/code-yeongyu/pi-webfetch/actions/runs/30711016262. The main-protection ruleset still requires Node 20/22 contexts while this PR intentionally emits Node 22/24; please update ruleset 15822204, then merge with a merge commit after CI is green. |
5 tasks
code-yeongyu
requested changes
Sep 24, 2026
code-yeongyu
left a comment
Owner
There was a problem hiding this comment.
This runtime bump is directionally right (Node 22.19, CI 22/24) but cannot land as-is.
Findings:
package.json:35-37(peerDependencies):@earendil-works/pi-ai,@earendil-works/pi-coding-agent, and@earendil-works/pi-tuiare pinned to^0.83.0. Caret ranges reject downstream date-versioned runtimes (for example2026.9.24). Peer range for@earendil-works/pi-*must be*(or>=0.87.0if a 0.87 API is required). Never^0.83/^0.87.package.json:35-37: 0.83 is stale versus current upstream0.87.1..github/workflows/ci.yml:26(matrix.node): 22/24 is the right matrix, but the refresh also moves install/test to Bun 1.4.2 (oven-sh/setup-bun@v2,bun install --frozen-lockfile) plus annpm-consumerjob. This PR only swaps the node versions.
Closing as superseded by the dependency refresh once that PR merges. The Node 22.19 engine bump will be included there with * peers.
Owner
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification