Type-check and test the site in CI, add Dependabot - #6
Merged
Merged
Conversation
The site workflow only built the site. The viewer's Vitest suites (npm run test:viewer, 210 tests including the ones added in #4) and svelte-check (npm run check) ran only when someone remembered to run them locally. Both now run before the build, so a failure blocks the deploy. svelte-check currently reports 0 errors and 3 warnings in vendored viewer code; warnings don't fail it. Dependabot now opens a monthly grouped PR for GitHub Actions updates, so runtime deprecations like the Node 20 one fixed in #5 arrive as PRs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI now runs the viewer tests and the type check before every build. It used to only build, so the 210 viewer tests (including the ones #4 added) and svelte-check ran only when someone remembered to run them locally.
npm run check) and viewer tests (npm run test:viewer) run afternpm ciand before the build. On main, a failure in either stops the deploy.site/README.mdnow describes what CI runs.Current state of the checks
MarkingRail.svelte, one unused export inMeetingView.svelte), and warnings don't fail svelte-check. Fixing them belongs upstream in gocassini, not in this repo's vendored copy.build, so any required status check still matches.🤖 Generated with Claude Code