PFM-ISSUE-34453 - github-actions: Normalize package-lock.json resolved URLs onto the JFrog npm proxy (release/26.2) - #168
Merged
Kaltenbach merged 2 commits intoAug 14, 2026
Conversation
…nvariant check and PR guard
…d URLs onto the JFrog npm proxy
Kaltenbach
requested review from
alekhya-cplace,
senthanal and
slaven3kopic
as code owners
August 14, 2026 12:17
Kaltenbach
deleted the
fix/PFM-ISSUE-34453-normalize-package-lock-json/26.2
branch
August 14, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Branch 5 of 7 for PFM-ISSUE-34453. Normalizes this branch's
package-lock.jsonresolvedURLs onto the JFrognpm proxy, and adds the same lockfile tooling and PR guard.
The tooling is byte-identical to the seed (#163,
merged) — verified, not asserted:
Same on all seven branches. So the only thing needing review here is the lockfile commit, and that is machine-checked.
The substantive review happened on #163.
Two commits
./tools/scripts/lockfile/check-lockfile.sh --baseline HEAD~1.Evidence
"resolved"linegrep -c registry.npmjs.org package-lock.json→ 0 (558 entries total)check-lockfile.sh --baseline HEAD~1exits 0: graph identical to the baseline, exactly one registry prefixpr-checks.ymlWhy this matters now
The prefix-drop that motivates this is a regression in newer npm, measured 2026-08-14: npm 10.2.4 — which every
pipeline pins today via node 18.19.1 — rewrites correctly and resolves through the proxy, while npm 11.3.0 drops the
registry's path prefix and fails with an
E404masked as***. So nothing is failing in CI today, and everythingun-normalized fails the moment runners move to node 24. This is a prerequisite for that migration, not a cleanup
after it.
Known limitation, same as #163: the guard reports but cannot block until PFM-ISSUE-34465 (Rule Sets enforcement)
lands.