Update go modules (main) (minor) - #3285
Conversation
|
ff4d004 to
5f37272
Compare
5f37272 to
c8f3087
Compare
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Review · |
|
🤖 Finished Review · ✅ Success · Started 2:40 AM UTC · Completed 2:51 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Review · |
|
🤖 Review · |
|
🤖 Finished Review · ✅ Success · Started 2:51 AM UTC · Completed 3:04 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 2:41 AM UTC · Completed 2:51 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Review · |
|
🤖 Finished Review · ✅ Success · Started 3:17 AM UTC · Completed 3:29 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Review · |
|
🤖 Finished Review · ✅ Success · Started 2:24 AM UTC · Completed 2:33 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Review · |
|
🤖 Review · |
|
🤖 Finished Review · ✅ Success · Started 2:26 AM UTC · Completed 2:37 AM UTC |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Review · |
|
🤖 Finished Review · ✅ Success · Started 2:37 AM UTC · Completed 2:51 AM UTC |
|
🤖 Finished Review · ❌ Failure · Started 2:20 AM UTC · Completed 2:26 AM UTC Commit: |
|
🤖 Finished Review · ✅ Success · Started 2:29 AM UTC · Completed 2:42 AM UTC Commit: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Review · Commit: |
|
🤖 Review · Commit: |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
🤖 Finished Review · ✅ Success · Started 2:42 AM UTC · Completed 2:55 AM UTC Commit: |
|
|
||
| // Maybe less important in acceptance, but it seems sensible to use the fork here too | ||
| replace github.com/google/go-containerregistry => github.com/conforma/go-containerregistry v0.21.8-0.20260626175242-ae5f0ae7a0b0 | ||
| replace github.com/google/go-containerregistry => github.com/conforma/go-containerregistry f9eefe19c7b2 |
There was a problem hiding this comment.
[high] invalid go.mod syntax
The replace directive uses a bare commit hash f9eefe19c7b2 without the required pseudo-version prefix. Go modules require versions in the form vX.Y.Z-YYYYMMDDHHMMSS-abcdefabcdef. The main go.mod correctly uses v0.21.8-0.20260702142841-f9eefe19c7b2 for the same replacement. This will cause go mod tidy or build failures in the acceptance module.
Suggested fix: Change to replace github.com/google/go-containerregistry => github.com/conforma/go-containerregistry v0.21.8-0.20260702142841-f9eefe19c7b2 (matching the main go.mod).
| github.com/Microsoft/go-winio v0.6.3-0.20251027160822-ad3df93bed29 // indirect | ||
| github.com/ProtonMail/go-crypto v1.3.0 // indirect | ||
| github.com/alessio/shellescape v1.4.2 // indirect | ||
| github.com/Microsoft/go-winio 75610162e7da // indirect |
There was a problem hiding this comment.
[high] invalid go.mod syntax
Dependency github.com/Microsoft/go-winio 75610162e7da uses a bare commit hash without the required v-prefixed pseudo-version. The same issue appears in go.mod (line 100) and tools/go.mod (line 88). This will cause module resolution failures across all three modules.
Suggested fix: Replace the bare commit hash with the proper pseudo-version in all three go.mod files (run go mod tidy in each module directory).
| github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect | ||
| github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect | ||
| github.com/prometheus/client_golang v1.23.2 // indirect | ||
| github.com/planetscale/vtprotobuf 8ae5a48058df // indirect |
There was a problem hiding this comment.
[high] invalid go.mod syntax
Dependency github.com/planetscale/vtprotobuf 8ae5a48058df uses a bare commit hash without the required v-prefixed pseudo-version. The same issue appears in tools/go.mod (line 442). This will cause module resolution failures.
Suggested fix: Replace the bare commit hash with the proper pseudo-version (run go mod tidy).
| // gocloud.dev >= v0.44.0 removed the docstore/awsdynamodb package, which | ||
| // tektoncd/chains (via tektoncd/cli) still imports | ||
| replace gocloud.dev => gocloud.dev v0.43.0 | ||
| replace gocloud.dev => gocloud.dev v0.46.0 |
There was a problem hiding this comment.
[medium] stale-comment
The replace directive now pins gocloud.dev to v0.46.0, but the comment states gocloud.dev >= v0.44.0 removed the docstore/awsdynamodb package. Since tektoncd/chains and tektoncd/cli were bumped to newer versions that likely no longer need this package, the replace directive and stale comment should be cleaned up.
Suggested fix: Verify whether the replace is still needed by running go mod tidy without it. If it resolves, remove both the directive and comment.
This PR contains the following updates:
v1.3.0→v1.4.0v0.20.0→v0.22.0v0.23.0v1.21.0→v1.24.0v1.25.0v1.11.0→v1.12.0v1.13.0v1.31.0→v1.33.0v1.0.0→v1.2.0v1.25.0→v1.30.0v1.62.0→v1.64.0v0.16.0→v0.17.1v0.16.0→v0.17.1v0.6.0→v0.8.1v0.15.0→v0.20.0v1.21.1→v1.22.0v1.13.1→v1.14.0v1.4.0→v1.5.0v1.6.0→v1.8.0v0.10.0→v0.11.0v0.10.0→v0.11.0v1.32.0→v1.35.0v0.55.0→v0.59.0v0.55.0→v0.59.0v1.45.2→v1.60.1v3.4.0→v3.5.0ad3df93→7561016v1.3.0→v1.4.1v1.2.5→v1.6.8v2.23.1→v2.27.0v1.4.2→v1.6.0v1.2.2→v1.5.3v1.3.9→v1.4.12v0.1.0→v0.2.1v1.42.0→v1.43.4v1.55.3→v1.60.4v1.38.10→v1.41.4v1.51.1→v1.55.4v1.97.3→v1.106.5v1.107.0v1.0.11→v1.5.4v1.30.17→v1.33.4v4.6.1→v4.10.0v5.6.0→v5.8.0v0.10.1→v0.11.7v0.10.0→v0.11.0v2.6.0→v2.7.0ae5f0ae→f9eefe1v2.2.3→v2.3.0v3.19.0→v3.20.0v0.15.0→v0.16.0v0.6.1→v0.7.0v0.13.7→v0.14.0v2.2.0→v2.4.23a137a8→ffadbf3220c5c2→c455327v1.11.5→v1.12.0v29.5.3+incompatible→v29.7.2+incompatiblev0.7.0→v0.8.1v1.0.4→v1.1.0v2.9.0→v2.13.10v1.2.6→v1.3.0v0.23.1→v0.24.0v0.24.0→v0.25.0v0.32.4→v0.33.0v0.32.4→v0.33.0v0.30.0→v0.33.0v0.26.4→v0.27.0v0.26.4→v0.27.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v0.26.1→v0.28.0v1.18.0→v1.19.2f665c8d→c99c5cfd62b90e→e7be49av2.11.4→v2.12.2v0.28.0→v0.30.0v0.31.0v25.2.10+incompatible→v25.12.19+incompatible7a66278→7b32099098045d→7b32099v1.1.0→v1.2.0545e8a4→ef3492d5a72de7→1fb717av2.22.0→v2.23.0v2.29.0→v2.30.0v2.23.0→v2.24.0v1.22.0→v1.23.0v1.39.1→v1.42.1v0.10.0→v0.11.1v1.1.2→v1.2.0v0.9.1→v0.12.0v0.10.0→v0.11.0661be99→a09352bv1.8.2→v1.11.0v1.2.0→v1.6.0v1.10.0→v1.20.0v1.18.6→v1.19.2v2.3.0→v2.4.0v0.8.0→v0.9.0v1.0.0→v1.3.0v3.0.13→v3.2.0v0.20260309.0→v0.20260804.0v1.11.2→v1.12.3v1.3.0→v1.4.139d0f17→341c2f0b1d8f4d→341c2f0v1.8.10→v1.18.11v0.5.0→v0.6.0v1.1.1→v1.3.0v0.29.0→v0.32.2v0.2.0→v0.3.3v0.6.0→v0.7.0v0.7.1→v0.12.2v1.2.0→v1.3.0v0.68.2→v0.69.0v1.15.2→v1.19.0v1.15.2→v1.19.0v2.3.0→v2.4.320ebb0f→4e6772a0393e58→8ae5a485aafc22→884566082ca368→8845660v1.23.2→v1.24.1v0.68.0→v0.70.1v0.20.1→v0.21.1a481f6a→1fd8a60v0.2.0→v0.3.0v1.14.1→v1.16.0v0.11.0→v0.12.0v2.24.8-0.20260309165252-619ce2117e08→v2.28.0v3.23.12→v3.24.5v0.1.6→v0.2.2v3.0.4→v3.1.3v2.0.1→v2.3.0v2.2.2-0.20260601073857-5d098a2b6443→v2.3.0v1.1.4→v1.3.0v1.2.1→v1.3.0v2.0.3→v2.1.3v2.0.4→v2.1.3v0.7.0→v0.8.0v2.6.0→v2.8.1v0.26.2→v0.29.0v0.44.1→v0.46.0v0.35.0→v0.37.0