🚨 Update registry.access.redhat.com/ubi9/go-toolset Docker tag to v9 (main) - #3375
Conversation
|
🤖 Finished Review · ✅ Success · Started 2:25 AM UTC · Completed 2:34 AM UTC |
ReviewFindingsHigh
Low
Info
Next steps:
Previous runReview — ⚠ Changes RequestedSummaryThis automated Renovate PR changes the Findings🔴 High: Go version tagging scheme change risks build correctness (
|
5401302 to
26e07d2
Compare
|
🤖 Finished Review · ✅ Success · Started 2:21 AM UTC · Completed 2:28 AM UTC |
26e07d2 to
fc0a1df
Compare
|
🤖 Finished Review · ✅ Success · Started 2:17 AM UTC · Completed 2:21 AM UTC |
|
🤖 Finished Retro · ✅ Success · Started 5:36 PM UTC · Completed 5:47 PM UTC |
Retro: PR #3375 — Renovate go-toolset major version bump (autoclosed)Timeline
AssessmentReview quality was good. The review agent correctly identified a genuine correctness risk — the tagging scheme change means future Renovate updates would track UBI OS releases instead of Go versions, risking silent toolchain drift. The suggested remediation (verify Go version in the image, reconfigure Renovate to track Go-version-based tags) was actionable and appropriate. The third review was the most comprehensive and well-structured, showing improvement over iterations. The core inefficiency is well-documented. Three review agent runs on a bot PR that no human ever engaged with, followed by a retro agent run on the autoclosed result, consumed resources without driving any outcome. This is the same pattern identified across multiple prior retros. No new proposals — existing issues cover all findingsEvery improvement opportunity surfaced by this PR is already tracked by open issues:
|
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
fc0a1df to
61e71c9
Compare
|
🤖 Finished Review · ✅ Success · Started 2:47 AM UTC · Completed 2:58 AM UTC Commit: |
| ## Build | ||
|
|
||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.26.3@sha256:17c888d75753f128f6cbdc5587932c3abd2632ca8e0931aa27b9a60c7a75ac62 AS build | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:9.8-1786023237@sha256:5d26ff5606bd6590930e7cfc202b510e3fe2c7a7a1720860f444ab49c45128cb AS build |
There was a problem hiding this comment.
[high] api-contract
The go-toolset image tag changes from Go-version-based tagging (1.26.3) to UBI-release-based tagging (9.8-1786023237). The tag 9.8 refers to the RHEL 9.8 OS minor release, not the Go version. It is not possible to determine from the tag alone which Go version is bundled in this image. If the bundled Go version does not satisfy the go 1.26.3 directive in go.mod, the build will fail. Additionally, this tag scheme change means future Renovate updates will track UBI OS releases rather than Go versions, risking silent Go toolchain changes on subsequent updates.
Suggested fix: Verify the Go version bundled in the image (e.g., via podman run --rm go version). If compatible, reconfigure Renovate to continue tracking Go-version-based tags for this image.
| ## Build | ||
|
|
||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.26.3@sha256:17c888d75753f128f6cbdc5587932c3abd2632ca8e0931aa27b9a60c7a75ac62 AS build | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:9.8-1786023237@sha256:5d26ff5606bd6590930e7cfc202b510e3fe2c7a7a1720860f444ab49c45128cb AS build |
There was a problem hiding this comment.
[low] stale-reference
After this change, Dockerfile uses golang:1.26.3 (explicitly Go-version-pinned) while Dockerfile.dist uses go-toolset:9.8-1786023237 (UBI-release-pinned, Go version opaque). These are intentionally different base images from different registries, but both should provide the same Go version for consistent build behavior.
This PR contains the following updates:
1.26.3→9.8-1786023237Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: (UTC)
* 0-3 * * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.