Skip to content

Minor fixes - #402

Open
WaberZhuang wants to merge 5 commits into
containerd:mainfrom
WaberZhuang:main
Open

WaberZhuang wants to merge 5 commits into
containerd:mainfrom
WaberZhuang:main

Conversation

@WaberZhuang

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

  • skip erofs fs meta when rootfs is writable
  • fix & enhance device probe
  • device waiting timeout 0.5s -> 5s
  • drop log of Stat and Usage
  • fix the unlabelled initial layer so that, after switching from OverlayFS to OverlayBD, the unlabelled preparation can be dealt with correctly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com>
Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com>
Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com>
Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com>
Signed-off-by: zhuangbowei.zbw <zhuangbowei.zbw@alibaba-inc.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The readiness jump loses the discovered device path, causing successful attachments to time out.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Improves writable-rootfs handling and device attachment reliability while reducing noisy logs.

Changes:

  • Extends device polling and adds device-node readiness checks.
  • Refines writable-mode selection and EROFS fallback.
  • Removes routine Stat and Usage logs.
File summaries
File Description
pkg/snapshot/storage.go Extends and enhances device readiness probing.
pkg/snapshot/overlay.go Updates writable-mode, EROFS, and logging behavior.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pkg/snapshot/storage.go
}
devName = device
break
goto waitDevReady
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants