Skip to content

fix UB when opening an empty sparse layer #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youhangwang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix UB when opening an empty sparse layer #453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/overlaybd/lsmt/file.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,7 +1504,7 @@ IFileRW *open_file_rw(IFile *fdata, IFile *findex, bool ownership) {
if (LSMTSparseFile::create_mappings(fdata, mappings) == -1) {
LOG_ERROR_RETURN(0, nullptr, "failed to create segment mappings from sparse file!");
}
pi = create_memory_index0((const SegmentMapping *)&mappings[0], mappings.size(),
pi = create_memory_index0(mappings.data(), mappings.size(),
HeaderTrailer::SPACE / ALIGNMENT, stat.st_size / ALIGNMENT);
if (!pi) {
LOG_ERROR_RETURN(0, nullptr, "failed to create memory index from sparse file!");
Expand Down
Loading