fix: respect excludeContentTypes during entry sync in shared-stack se… - #277
Closed
ccarrascal wants to merge 1 commit into
Closed
Conversation
3 tasks
Contributor
|
Closing this PR as we have made the fixes in #279 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two plugin instances share the same type_prefix and plugin cache
(e.g. a main stack plus a shared/publisher stack), the instance without
an exclusion list overwrites the cached content-type list, causing the
excluded content types to be synced anyway. This produced duplicate
entries from the shared stack.
Re-apply excludeContentTypes filtering at the points where the cached
content-type list is consumed, so exclusions hold regardless of cache
ordering between instances:
FetchUnspecifiedContentTypes so references don't re-introduce
excluded types.
FetchSpecifiedContentTypesEntries and
FetchSpecifiedLocalesAndContentTypesEntries before entry sync.