-
Notifications
You must be signed in to change notification settings - Fork 2
Completion complete #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cafalchio
wants to merge
4
commits into
main
Choose a base branch
from
completion_complete
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Completion complete #121
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
65 changes: 57 additions & 8 deletions
65
crates/contextforge-data-plane-lib/src/gateway/mcp_service/completion.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,69 @@ | ||
| use rmcp::{ | ||
| ErrorData, RoleServer, | ||
| model::{CompleteRequestParams, CompleteResult, ErrorCode}, | ||
| model::{CompleteRequestParams, CompleteResult, ErrorCode, Reference}, | ||
| service::RequestContext, | ||
| }; | ||
| use tracing::info; | ||
|
|
||
| use crate::gateway::{ | ||
| mcp_call_validator::AuthorizedCallValidator, mcp_service::initialization::connect_backend_for_request, | ||
| routing_error::backend_forward_error, | ||
| }; | ||
|
|
||
| use super::McpService; | ||
|
|
||
| #[allow(clippy::unused_async)] | ||
| pub(super) async fn complete( | ||
| _: &McpService, | ||
| _: CompleteRequestParams, | ||
| _: RequestContext<RoleServer>, | ||
| mcp_service: &McpService, | ||
| request: CompleteRequestParams, | ||
| cx: RequestContext<RoleServer>, | ||
| ) -> Result<CompleteResult, ErrorData> { | ||
| Err(ErrorData { | ||
| code: ErrorCode::INVALID_REQUEST, | ||
| message: "Fan out not supported at the moment. Go to control plane".into(), | ||
| let mcp_call_validator = AuthorizedCallValidator::new("complete", &cx); | ||
| let (virtual_host, _claims) = mcp_call_validator.validate_stateless()?; | ||
|
|
||
| let route = match &request.r#ref { | ||
| Reference::Prompt(prompt) => virtual_host.prompts.get(&prompt.name), | ||
| Reference::Resource(resource) => { | ||
| virtual_host.resource_templates.get(&resource.uri).or_else(|| virtual_host.resources.get(&resource.uri)) | ||
| }, | ||
| _ => None, | ||
| }; | ||
| let Some(route) = route else { | ||
| return Err(ErrorData { | ||
| code: ErrorCode::INVALID_PARAMS, | ||
| message: "Routing problem... completion not found".into(), | ||
| data: None, | ||
| }); | ||
| }; | ||
|
|
||
| let backend_name = route.backend_name.clone(); | ||
| let completion_name = route.upstream_name.clone(); | ||
|
|
||
| let backend = virtual_host.backends.get(&backend_name).ok_or_else(|| ErrorData { | ||
| code: ErrorCode::INVALID_PARAMS, | ||
| message: "Routing problem... backend not found".into(), | ||
| data: None, | ||
| }) | ||
| })?; | ||
|
|
||
| let service_name = backend_name.clone(); | ||
| let mut backend_service = connect_backend_for_request(mcp_service, &backend_name, backend, &cx).await?; | ||
|
|
||
| let mut routed_request = request; | ||
| match &mut routed_request.r#ref { | ||
| Reference::Prompt(prompt) => prompt.name = completion_name, | ||
| Reference::Resource(resource) => resource.uri = completion_name, | ||
| _ => {}, | ||
| } | ||
|
|
||
| let response = backend_service.complete(routed_request).await; | ||
|
|
||
| if let Err(error) = backend_service.close().await { | ||
| tracing::warn!("complete: backend cleanup failed backend_name = {service_name} error = {error:?}"); | ||
| } | ||
|
|
||
| let response = response.map_err(|error| backend_forward_error("complete", &service_name, &error))?; | ||
|
|
||
| info!("complete: backend {service_name} returned {} contents", response.completion.values.len()); | ||
|
|
||
| Ok(response) | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
server/discovercurrently advertises no completions capability, so capability-aware clients will never invoke this handler.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be addressed on the discover.