Delete never-edited/never-acted/no-ship salvage classes (CL-6994) - #613
Merged
Merged
Conversation
…olicy salvage classes (CL-6994) Re-apply on current main: task re-dispatch is never refused now (admit() always succeeds); turn-budget salvage still throttles same-brief retries. Removes the requireEdit plumbing, the shell-write half of shell-evidence.ts (read detection for requireEvidence stays), the shell-write contribution to editedPaths, and the now-dead hard-block salvage nudge in the parent director (look-tour.ts).
TheGreatAxios
enabled auto-merge (squash)
August 24, 2026 09:21
This was referenced Aug 24, 2026
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…olicy salvage classes (CL-6994) (#613) Re-apply on current main: task re-dispatch is never refused now (admit() always succeeds); turn-budget salvage still throttles same-brief retries. Removes the requireEdit plumbing, the shell-write half of shell-evidence.ts (read detection for requireEvidence stays), the shell-write contribution to editedPaths, and the now-dead hard-block salvage nudge in the parent director (look-tour.ts).
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…olicy salvage classes (CL-6994) (#613) Re-apply on current main: task re-dispatch is never refused now (admit() always succeeds); turn-budget salvage still throttles same-brief retries. Removes the requireEdit plumbing, the shell-write half of shell-evidence.ts (read detection for requireEvidence stays), the shell-write contribution to editedPaths, and the now-dead hard-block salvage nudge in the parent director (look-tour.ts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/main(post CL-6946 part 2: delete prose-based sub-agent stop-reason matchers #610 structured stop reasons, post Delete repetition detection outright (CL-6995) #612 repetition/no-progress removal), replacing the earlier PR Delete never-edited/never-acted/no-ship/no-progress salvage classes #611 which had drifted into 9-file conflicts.HARD_BLOCK_SALVAGES/isHardBlockSalvageand the fingerprint-refusal branch inadmit()— task re-dispatch of an identical brief is never refused now.admit()always succeeds; turn-budget salvage still throttles repeated same-brief retries viadispatchCount.never-edited,never-acted, andno-shipstop reasons/salvage classes end-to-end:ForcedStopReason/SubAgentStopReason,evaluateSubAgentStop'severHadToolCalls/requireEditbranches, therequireEditplumbing throughnudge-director.ts/run.ts, and their parent hints/summaries instop-policy.ts.task-tool.ts's deadrecordRefusal/refusalLogpath.shell-evidence.ts(SHELL_WRITE_PROGRAMS, in-place-flag handling, redirection tracking) — read detection for therequireEvidence/CritiqueDirector gate is unchanged.thrash.ts's shell-write contribution toeditedPaths; the typed-tool contribution stays asinterventions.jsonldiagnostics only, feeding no stop decision.src/agent/director.ts's entire hard-block salvage nudge subsystem (salvageNudgeFired,pendingSalvageNudge,applySalvageNudge,pendingTaskCallIds) andsrc/agent/look-tour.ts(PRIMARY_SALVAGE_NUDGE) — both existed solely to nudge the parent after a hard-block salvage, which no longer exists.## [Unreleased].Net: -511 lines (111 insertions, 622 deletions across 17 files).
Test plan
bun run check(lint, typecheck, build, test) green — 5323 pass, 0 fail.