Skip to content

Delete never-edited/never-acted/no-ship salvage classes (CL-6994) - #613

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-6994-delete-policy-salvage-classes-v2
Aug 24, 2026
Merged

Delete never-edited/never-acted/no-ship salvage classes (CL-6994)#613
TheGreatAxios merged 1 commit into
mainfrom
cl-6994-delete-policy-salvage-classes-v2

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Re-applies CL-6994's deletion on current origin/main (post CL-6946 part 2: delete prose-based sub-agent stop-reason matchers #610 structured stop reasons, post Delete repetition detection outright (CL-6995) #612 repetition/no-progress removal), replacing the earlier PR Delete never-edited/never-acted/no-ship/no-progress salvage classes #611 which had drifted into 9-file conflicts.
  • Deletes HARD_BLOCK_SALVAGES / isHardBlockSalvage and the fingerprint-refusal branch in admit() — task re-dispatch of an identical brief is never refused now. admit() always succeeds; turn-budget salvage still throttles repeated same-brief retries via dispatchCount.
  • Deletes the never-edited, never-acted, and no-ship stop reasons/salvage classes end-to-end: ForcedStopReason/SubAgentStopReason, evaluateSubAgentStop's everHadToolCalls/requireEdit branches, the requireEdit plumbing through nudge-director.ts/run.ts, and their parent hints/summaries in stop-policy.ts.
  • Deletes task-tool.ts's dead recordRefusal/refusalLog path.
  • Deletes the shell-write half of shell-evidence.ts (SHELL_WRITE_PROGRAMS, in-place-flag handling, redirection tracking) — read detection for the requireEvidence/CritiqueDirector gate is unchanged.
  • Deletes thrash.ts's shell-write contribution to editedPaths; the typed-tool contribution stays as interventions.jsonl diagnostics only, feeding no stop decision.
  • Dead-by-consequence found and removed: src/agent/director.ts's entire hard-block salvage nudge subsystem (salvageNudgeFired, pendingSalvageNudge, applySalvageNudge, pendingTaskCallIds) and src/agent/look-tour.ts (PRIMARY_SALVAGE_NUDGE) — both existed solely to nudge the parent after a hard-block salvage, which no longer exists.
  • Rewrote/deleted tests asserting the deleted classes fire; kept coverage for turn-budget/cancelled/deadline/incomplete-report paths.
  • CHANGELOG entry under ## [Unreleased].

Net: -511 lines (111 insertions, 622 deletions across 17 files).

Test plan

  • bun run check (lint, typecheck, build, test) green — 5323 pass, 0 fail.

…olicy salvage classes (CL-6994)

Re-apply on current main: task re-dispatch is never refused now (admit()
always succeeds); turn-budget salvage still throttles same-brief retries.
Removes the requireEdit plumbing, the shell-write half of shell-evidence.ts
(read detection for requireEvidence stays), the shell-write contribution to
editedPaths, and the now-dead hard-block salvage nudge in the parent
director (look-tour.ts).
@linear-code

linear-code Bot commented Aug 24, 2026

Copy link
Copy Markdown

CL-6994

@TheGreatAxios
TheGreatAxios enabled auto-merge (squash) August 24, 2026 09:21
@TheGreatAxios
TheGreatAxios merged commit 80ae487 into main Aug 24, 2026
5 checks passed
TheGreatAxios added a commit that referenced this pull request Aug 27, 2026
…olicy salvage classes (CL-6994) (#613)

Re-apply on current main: task re-dispatch is never refused now (admit()
always succeeds); turn-budget salvage still throttles same-brief retries.
Removes the requireEdit plumbing, the shell-write half of shell-evidence.ts
(read detection for requireEvidence stays), the shell-write contribution to
editedPaths, and the now-dead hard-block salvage nudge in the parent
director (look-tour.ts).
TheGreatAxios added a commit that referenced this pull request Aug 27, 2026
…olicy salvage classes (CL-6994) (#613)

Re-apply on current main: task re-dispatch is never refused now (admit()
always succeeds); turn-budget salvage still throttles same-brief retries.
Removes the requireEdit plumbing, the shell-write half of shell-evidence.ts
(read detection for requireEvidence stays), the shell-write contribution to
editedPaths, and the now-dead hard-block salvage nudge in the parent
director (look-tour.ts).
@TheGreatAxios
TheGreatAxios deleted the cl-6994-delete-policy-salvage-classes-v2 branch August 28, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant