Remove back-compat branch in evaluateSubAgentStop - #616
Merged
TheGreatAxios merged 1 commit intoAug 24, 2026
Merged
Conversation
lastAssistantText is now required so every call path gets the incomplete-report nudge instead of letting omitted text complete a tool-less turn unconditionally.
TheGreatAxios
enabled auto-merge (squash)
August 24, 2026 10:09
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
lastAssistantText is now required so every call path gets the incomplete-report nudge instead of letting omitted text complete a tool-less turn unconditionally.
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
lastAssistantText is now required so every call path gets the incomplete-report nudge instead of letting omitted text complete a tool-less turn unconditionally.
TheGreatAxios
deleted the
cl-6788-remove-the-back-compat-branch-that-lets-a-worker-complete
branch
August 28, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastAssistantTextinevaluateSubAgentStopis now required; the omitted-text branch that unconditionally completed a tool-less turn is deleted.nudge-director.ts, which already always passed the text) now gets theincomplete-reportnudge, then salvage, when a tool-using run ends in envelope-less narration.Test plan
src/subagent/index.test.ts: the one test that omittedlastAssistantText(asserting unconditional"complete") now passeslastAssistantText: ""and asserts"incomplete-report"— this is the exact hole the ticket closes. All otherhasToolCalls: truecall sites got an explicitlastAssistantText: ""since it's now a required field they don't otherwise exercise.bun run checkpasses (lint, typecheck, build, 5324 tests).