docs: correct loop-control subsystem descriptions in ARCHITECTURE.md/PRODUCT.md - #620
Merged
TheGreatAxios merged 2 commits intoAug 24, 2026
Conversation
…trol subsystem repetition.ts, period-detection.ts, the tool-fingerprint thrash/backstop checks, requireEdit, never-acted/never-edited/no-progress/repetition stop classes, the hard-block re-dispatch refusal, and the default 30-turn leaf cap are gone. Describe the leaf stops, the fleet dispatch ledger, the task-tool watchdog exemption, and the primary-session nudge as they actually behave today instead of citing deleted files and thresholds.
CL-7001 is removing the same claim from the actual prompt text (src/agent/prompts.ts, skywalker/package.ts) since no concurrency cap exists in code. Removing it here too so the two land consistent.
TheGreatAxios
force-pushed
the
cl-7003-docsarchitecturemd-and-productmd-describe-the-loop-control
branch
from
August 24, 2026 13:46
b3e70ba to
5486df0
Compare
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…PRODUCT.md (#620) * docs: correct ARCHITECTURE.md and PRODUCT.md for the deleted loop-control subsystem repetition.ts, period-detection.ts, the tool-fingerprint thrash/backstop checks, requireEdit, never-acted/never-edited/no-progress/repetition stop classes, the hard-block re-dispatch refusal, and the default 30-turn leaf cap are gone. Describe the leaf stops, the fleet dispatch ledger, the task-tool watchdog exemption, and the primary-session nudge as they actually behave today instead of citing deleted files and thresholds. * docs: drop the stale hard-cap-4-workers prompt description CL-7001 is removing the same claim from the actual prompt text (src/agent/prompts.ts, skywalker/package.ts) since no concurrency cap exists in code. Removing it here too so the two land consistent.
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…PRODUCT.md (#620) * docs: correct ARCHITECTURE.md and PRODUCT.md for the deleted loop-control subsystem repetition.ts, period-detection.ts, the tool-fingerprint thrash/backstop checks, requireEdit, never-acted/never-edited/no-progress/repetition stop classes, the hard-block re-dispatch refusal, and the default 30-turn leaf cap are gone. Describe the leaf stops, the fleet dispatch ledger, the task-tool watchdog exemption, and the primary-session nudge as they actually behave today instead of citing deleted files and thresholds. * docs: drop the stale hard-cap-4-workers prompt description CL-7001 is removing the same claim from the actual prompt text (src/agent/prompts.ts, skywalker/package.ts) since no concurrency cap exists in code. Removing it here too so the two land consistent.
TheGreatAxios
deleted the
cl-7003-docsarchitecturemd-and-productmd-describe-the-loop-control
branch
August 28, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/ARCHITECTURE.mdanddocs/PRODUCT.mddescribed a loop-control subsystem (repetition detection, tool-fingerprint thrash/backstop,requireEdit,never-acted/never-edited/no-progress/repetitionstop classes, hard-blocked re-dispatch, default 30-turn leaf cap) that was deleted in a recent release. Rewrote those sections to describe current behavior, verified line-by-line against the tree.What changed and why
ARCHITECTURE.md
complete,incomplete-report/incomplete-report-stop,turn-budgetonly whenmaxTurnsis finite,report-forced,cancelled) and thatrequireEvidenceonly checks reads (shell reads included viashell-evidence.ts), with no write-evidence requirement.maxTurns, then suggest a different approach after 3 same-brief turn-budget salvages) but never refuses a re-dispatch — the hard-block is gone.src/agent/director.tsanymore. Main-session loop protection is now the one-shottoolOnlyNudgeFiredcheck-in nudge only; there is no automated stop for the primary session.stallednow compares itself toturn-budget/cancelled, not to the deleted stop classes.turn-budgetonly (no-progress no longer exists).tasktool exemption is unconditional, not because the leaf is otherwise bounded —maxTurnsis unbounded by default,deadlineMsis opt-in, and there is no no-progress/thrash stop.src/agent/prompts.ts,skywalker/package.ts) since no concurrency cap exists in code; landing both changes keeps prompt and doc consistent.PRODUCT.md
src/; it survived only as prompt wording, not enforcement.incomplete-report-stop,turn-budgetonly when finite,stalled,cancelled/deadlineMs).Found beyond the listed scope
src/subagent/intervention-log.tshas a stale doc comment citingIDENTICAL_REPEAT_MINandTURNS_SINCE_USER_MESSAGE_BACKSTOP(both deleted). Not fixed here: this PR stays docs-only, and an in-session request to fix it mid-review was blocked by the harness's own src/-write guard, which is correctly enforcing that boundary while other lanes touchsrc/subagent/. Flagging for a follow-up.Test plan
bun run check(lint/typecheck/build/test) — all green, 5340 tests passed, 0 failures.No CHANGELOG entry — docs-only change.