Make ask_operator use a full-shell overlay - #686
Merged
TheGreatAxios merged 4 commits intoAug 25, 2026
Merged
Conversation
Inset mode clipped long questions and option lists. Operator asks now open full_shell; permission gates stay inset. Agents must put long rationale in chat first, then ask with short labels.
Operator asks now open full_shell (CL-7067), which hides the landing. The slide-only-as-needed coverage belongs on the inset permission path.
A three-item empty permissions open left message delta 0, so the slide test would pass without the float moving. The many-choices landing case still opened operator full_shell, which hides landing. Retarget both to heavy inset permissions, and pin that full_shell keeps more decision context rows than inset for the same long body.
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
* Make ask_operator use a full-shell overlay Inset mode clipped long questions and option lists. Operator asks now open full_shell; permission gates stay inset. Agents must put long rationale in chat first, then ask with short labels. * Retarget landing inset overlay test to permissions Operator asks now open full_shell (CL-7067), which hides the landing. The slide-only-as-needed coverage belongs on the inset permission path. * Harden landing overlay tests for inset pressure and full_shell budget A three-item empty permissions open left message delta 0, so the slide test would pass without the float moving. The many-choices landing case still opened operator full_shell, which hides landing. Retarget both to heavy inset permissions, and pin that full_shell keeps more decision context rows than inset for the same long body. * Format overlays.test.ts choices array for Prettier
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
* Make ask_operator use a full-shell overlay Inset mode clipped long questions and option lists. Operator asks now open full_shell; permission gates stay inset. Agents must put long rationale in chat first, then ask with short labels. * Retarget landing inset overlay test to permissions Operator asks now open full_shell (CL-7067), which hides the landing. The slide-only-as-needed coverage belongs on the inset permission path. * Harden landing overlay tests for inset pressure and full_shell budget A three-item empty permissions open left message delta 0, so the slide test would pass without the float moving. The many-choices landing case still opened operator full_shell, which hides landing. Retarget both to heavy inset permissions, and pin that full_shell keeps more decision context rows than inset for the same long body. * Format overlays.test.ts choices array for Prettier
TheGreatAxios
deleted the
cl-7067-ask_operator-must-be-readable-full-shell-overlay-or-chat
branch
August 28, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ask_operator/operator.gate) open infull_shellso long questions and option lists stay readable; permission gates remain inset.ask_operatorquestion with short option labels.Verification
bun run typecheckpassesbun test src/tui/overlays.test.ts src/prompts.test.ts src/tui/geometry.test.ts src/tui/gate-wire.test.ts src/tui/shell.test.ts src/tui/wave6.test.ts src/tui/approval-prompt-visibility.test.ts src/tui/overlay-overflow.test.ts— 219 pass, 0 failfull_shell; permissions overlay assertsinsetFixes CL-7067