Show operator questions as an inset overlay - #709
Merged
TheGreatAxios merged 2 commits intoAug 28, 2026
Conversation
TheGreatAxios
commented
Aug 28, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
lens: critic
verdict: clean
This branch restores operator questions to the inset overlay path so the chat-first rationale remains visible while choosing. I found no blocking or should-fix defects. The only full gate caveat is the unrelated cwd-path prompt test false positive documented in the PR body.
TheGreatAxios
commented
Aug 28, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
openOperatorOverlay no longer forces overlayMode: "full_shell", so ask_operator questions open as an inset overlay with the transcript visible.
No findings.
Notes
- This reintroduces the 8-row
DECISION_CONTEXT_ROWSclipping CL-7067 removed (pinned bysrc/tui/overlays.test.ts:283-286); CHANGELOG owns it as the trade-off and the prompt-side "short question, rationale in chat first" guidance from CL-7067 stays in place as the mitigation. full_shellplumbing insrc/tui/shell.ts(relayoutOverlayHost,decisionContextBudget,OpenListOverlayOpts.overlayMode) now has no production caller — onlyoverlays.test.ts:228. Follow-up deletion candidate.- Checks:
bun run typecheck,bun run lint,bun test src/tui/overlays.test.ts src/tui/landing.test.ts(44 pass). Fullbun test: 2 failures, both reproduce onorigin/main(src/prompts.test.ts:273trips on the worktree path containingask_operator;vendor/intx-inference/src/reactor.test.tsfails identically on main).
Drop OverlayMode full_shell from geometry resolve, shell relayout/budget paths, and OpenListOverlayOpts. Delete the mode-specific geometry and overlays tests. Document the removal in Unreleased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun test src/tui/overlays.test.ts -t "long body"fails before the implementation and passes after itbun test src/tui/overlays.test.tspassesbun run checkreaches the full test suite but hits an unrelated prompt-contract false positive because this worktree path containsask_operator; the same prompt test passes onorigin/mainFixes CL-7176