Restore first-run welcome before provider setup - #717
Closed
TheGreatAxios wants to merge 1 commit into
Closed
Conversation
Unconfigured launches jumped straight into model setup and skipped the orange mountain plus product line. Gate setup on settings.onboarded, show the welcome surface first, and stamp onboarded only after it completes so returning users still open setup directly.
Collaborator
Author
|
Closing as a duplicate of #718, which already landed on main (same welcome/onboarding tree; this branch only still carries a stale 0.3.8 version bump and Unreleased changelog wording). First-run welcome polish that is still worth doing (hold the filled mountain instead of looping into a fade, then auto-advance) will land on a new PR from current main rather than rebasing this conflicting branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corbits Code, your local software factorybefore provider/model setup.markOnboardedstamps only after the welcome gate completes.Verification
bun run checkpassesbun test ./src/tui/welcome.test.ts ./src/tui/onboarding.test.ts ./tests/unit/tui/onboarded-persistence.test.ts ./src/tui/provider-setup.test.ts ./src/tui/landing.test.ts ./src/tui/mark-anim.test.ts