Treat failed run.json with error as valid session state - #726
Merged
TheGreatAxios merged 2 commits intoAug 31, 2026
Merged
Conversation
loadState used to treat any parsed error field as a corrupt file, so a valid failed run with an error string was unreadable. Parse is now a tagged result, resume-by-id of a truly unreadable file throws one recovery line, and diagnostics go to structured log instead of stderr.
loadState now returns a tagged result so callers can tell a missing run.json from a present but unreadable one without restatting the file. Unreadable resume-by-id prints one recovery line; parse diagnostics stay in the structured log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run.jsonwith anerrorstring as valid state instead of a corrupt file.Verification
bun run testwas blocked by host git hooks rejecting fixture authors (CL-7267 is the helper for that).Fixes CL-7287