Keep approval persistence failures from crashing the session - #729
Merged
TheGreatAxios merged 2 commits intoAug 31, 2026
Merged
Conversation
A rejected Allow Always write already applied in memory and was logged, but the operator had no on-screen signal that later sessions would re-ask. Persist now uses a live provider-model getter so a later merge with mid-session model switching cannot capture a stale key.
TheGreatAxios
force-pushed
the
cl-7264-keep-approval-persistence-failures-non-fatal
branch
2 times, most recently
from
August 31, 2026 15:35
8b1e8b5 to
32431ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run testwas blocked by host git hooks rejecting fixture authors (CL-7267 is the helper for that).Fixes CL-7264