Recognize CLI help regardless of argument position - #738
Merged
TheGreatAxios merged 3 commits intoSep 1, 2026
Merged
Conversation
Value flags were binding the next token even when it was --help or another flag. Scan argv for help first, and reject flag-shaped tokens as required option values.
Value flags now reject --* and -h via isFlagToken instead of every dash-prefixed token, so POSIX paths like --cwd -my-dir still bind.
The previous case passed an absolute path whose last segment was -my-dir, so reverting isFlagToken to startsWith("-") would still pass CI while breaking corbits --cwd -my-dir. Bind the argv token itself and assert cwd is resolve("-my-dir"). Also cover omitted --cwd/--config/--profile.
TheGreatAxios
force-pushed
the
cl-7092-recognize-help-consistently-and-reject-flags-as-option
branch
from
September 1, 2026 04:11
980b9cd to
7b55aaa
Compare
TheGreatAxios
enabled auto-merge
September 1, 2026 04:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--help,-h, or another option as their value.Verification
bun run checkpasses (lint, typecheck, build, full test suite)resume -hFixes CL-7092
Fixes #483