Add /connect and fix Option+A on composed macOS input - #739
Merged
TheGreatAxios merged 4 commits intoSep 1, 2026
Merged
Conversation
TheGreatAxios
changed the title
TheGreatAxios
force-pushed
the
cl-7094-make-the-add-provider-shortcut-work-on-non-us-macos-keyboard
branch
from
September 1, 2026 04:12
0384976 to
a91b6a0
Compare
TheGreatAxios
enabled auto-merge
September 1, 2026 04:12
Slash /connect opens Add Provider from any layout. Option+A still works, including terminals that emit å/Å without the option modifier.
Esc from /connect was reopening the model picker because the opener always wired onCancel to openModels. Only Alt+A from an already-open picker needs that return path.
The footer still advertised only Alt+A, which is a dead chord on layouts whose Option+A is not å/Å. Tests now cover closed-prompt å, other composed glyphs, sequence-only å, typed /connect Esc, and Alt+A Esc through the key path.
TheGreatAxios
force-pushed
the
cl-7094-make-the-add-provider-shortcut-work-on-non-us-macos-keyboard
branch
from
September 1, 2026 04:18
a91b6a0 to
d42a578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/connectopens Add Provider from any keyboard layout (layout-proof path).å/Åfor Option+A without the option modifier also open it in/model./connectdismisses Add Provider. Esc after Alt+A from/modelstill returns to the model list.åin/modelis treated as that shortcut only when Add Provider is offered.Verification
/connect, composedå/Å, unwiredåstill filtering, bare ASCIIa, and both Esc pathsbun run checklint/typecheck/build pass; full suite green on the follow-up commitFixes CL-7094
Fixes #482