Skip to content

Normalize OpenCode Go null tool calls - #750

Closed
TheGreatAxios wants to merge 1 commit into
mainfrom
cl-7367-fix-tool_calls-null-rejection-killing-all-chat-completions
Closed

Normalize OpenCode Go null tool calls#750
TheGreatAxios wants to merge 1 commit into
mainfrom
cl-7367-fix-tool_calls-null-rejection-killing-all-chat-completions

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • OpenCode Go treats nullable tool-call deltas as absent
  • Other OpenAI-compatible sources retain strict response validation
  • The provider quirk remains explicit and upstreamable

Verification

  • bun run check passes
  • Focused adapter, source, and vendored parser tests pass

Refs CL-7367

@linear-code

linear-code Bot commented Sep 1, 2026

Copy link
Copy Markdown

CL-7367

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full origin/main...HEAD diff. No blocking or should-fix findings.

The OpenCode Go source opts into null tool-call normalization while default and malformed non-null values remain strict. Focused adapter, source, and vendored parser tests pass.

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Superseded by #753. Current main routes OpenCode Go chat-completions through a dedicated adapter that normalizes null role and tool_calls fields before the strict OpenAI parser, while malformed non-null and generic OpenAI-compatible inputs remain strict. Focused coverage passes for the CL-7367 runtime path.

@TheGreatAxios
TheGreatAxios deleted the cl-7367-fix-tool_calls-null-rejection-killing-all-chat-completions branch September 2, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant