Normalize OpenCode Go null tool calls - #750
Closed
TheGreatAxios wants to merge 1 commit into
Closed
Conversation
TheGreatAxios
commented
Sep 1, 2026
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed the full origin/main...HEAD diff. No blocking or should-fix findings.
The OpenCode Go source opts into null tool-call normalization while default and malformed non-null values remain strict. Focused adapter, source, and vendored parser tests pass.
Collaborator
Author
|
Superseded by #753. Current main routes OpenCode Go chat-completions through a dedicated adapter that normalizes null role and tool_calls fields before the strict OpenAI parser, while malformed non-null and generic OpenAI-compatible inputs remain strict. Focused coverage passes for the CL-7367 runtime path. |
TheGreatAxios
deleted the
cl-7367-fix-tool_calls-null-rejection-killing-all-chat-completions
branch
September 2, 2026 05:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run checkpassesRefs CL-7367