Seed model offerings in declared priority order - #546
Open
pratikbuilds wants to merge 4 commits into
Open
Conversation
TheGreatAxios
self-requested a review
September 2, 2026 07:26
TheGreatAxios
requested changes
Sep 2, 2026
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Review · Request changes
Catalog seeding assigns each declared provider/model pair a deterministic priority.
Findings
packages/hub-client/src/seed.ts:1341— Could the seed reconcile an existing offering's priority rather than skip the 409? Tenants seeded before this change retain equal priorities on rerun, so the intended Sonnet-first order never reaches those catalogs and resolution continues to use the tie-breaker.
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Critic · Comment
Catalog seeding flattens declared provider and model order into offering priorities.
Findings
packages/hub-client/src/seed.ts:1341— Existing offerings are skipped after a 409, so a catalog seeded before this change keeps the former equal priorities even after rerunning the seed command. A re-run regression should establish that upgrade behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
This implements the fresh-seed priority direction described in #541. It does not add an environment variable for selecting Sonnet, Opus, or another model;
ANTHROPIC_API_KEYremains credential-only.Verification
bun run checkFixes #541