Skip to content

Seed model offerings in declared priority order - #546

Open
pratikbuilds wants to merge 4 commits into
corbitsdev:mainfrom
pratikbuilds:cl-541-anthropic-default-model
Open

Seed model offerings in declared priority order#546
pratikbuilds wants to merge 4 commits into
corbitsdev:mainfrom
pratikbuilds:cl-541-anthropic-default-model

Conversation

@pratikbuilds

Copy link
Copy Markdown
Contributor

Summary

  • assign each seeded model offering a distinct provider-major, model-major priority
  • make the first curated model for a provider win both Settings and runtime resolution
  • cover the fresh Anthropic seed and cross-provider offsets with regression tests

Scope

This implements the fresh-seed priority direction described in #541. It does not add an environment variable for selecting Sonnet, Opus, or another model; ANTHROPIC_API_KEY remains credential-only.

Verification

  • bun run check
  • 44 hub-client seed tests
  • 33 inference resolver tests
  • Greybeard and Critique reviews clean

Fixes #541

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review · Request changes

Catalog seeding assigns each declared provider/model pair a deterministic priority.

Findings

  • packages/hub-client/src/seed.ts:1341 — Could the seed reconcile an existing offering's priority rather than skip the 409? Tenants seeded before this change retain equal priorities on rerun, so the intended Sonnet-first order never reaches those catalogs and resolution continues to use the tie-breaker.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critic · Comment

Catalog seeding flattens declared provider and model order into offering priorities.

Findings

  • packages/hub-client/src/seed.ts:1341 — Existing offerings are skipped after a 409, so a catalog seeded before this change keeps the former equal priorities even after rerunning the seed command. A re-run regression should establish that upgrade behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anthropic default model is inconsistent between seed configuration and UI

2 participants