Deploy Agent Builder definitions through the native source pipeline (CL-7363) - #560
Merged
TheGreatAxios merged 7 commits intoSep 2, 2026
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-7363-agent-builder-native
branch
from
September 2, 2026 07:44
0201645 to
16c7978
Compare
TheGreatAxios
changed the base branch from
cl-7361-native-deploy
to
cl-7362-deploy-approval
September 2, 2026 07:45
TheGreatAxios
force-pushed
the
cl-7363-agent-builder-native
branch
from
September 2, 2026 08:48
16c7978 to
cebb8bf
Compare
TheGreatAxios
force-pushed
the
cl-7363-agent-builder-native
branch
from
September 2, 2026 09:13
cebb8bf to
cefe2b3
Compare
TheGreatAxios
force-pushed
the
cl-7363-agent-builder-native
branch
from
September 2, 2026 09:31
cefe2b3 to
89f86bf
Compare
A create or PATCH-carried retarget now must clear the same two gates before it is persisted: resolveLaunchableDefinition must resolve the asset, and the acting principal must be authorized for workflow-definition:<id>/read — the same verb listRoutineTargets already checks per row. A denial is a typed 403 alongside the existing 400/404/409 target envelopes, on both the tenant-session and Myra's workflow-run-authenticated routine surfaces. Also routes a pre-existing catch in postRoutineEnabledNotice through reportError, since this change's diff now touches that line and check:report-error requires it.
Route tests that asserted DefinitionFreezer freeze/refreeze calls now assert the injected WorkflowDeployer is called with the commit each write produces, and a new source-grep test asserts this package never imports @corbits/workflow-freeze (CL-7363).
Every content-mutating agent-directory route (create, restore, capability add, instructions edit, skills edit, skill pin) used to self-freeze its definition through @corbits/workflow-freeze's DefinitionFreezer, a hub-local path that bypasses the native sidecar probe. Cut over to the same WorkflowDeployer the agent-authored-workflow registry calls: write the source tree, then deploy the resulting commit through install -> sidecar probe -> gate -> freeze. A sidecar-unavailable deploy now returns the same 502 envelope the native deployments route uses, with no fallback to freezing. Removes @corbits/workflow-freeze from agent-directory's dependencies entirely.
AGENTS-PAGE.md's "Creating an agent" steps described a workflow.json write followed by ensureWorkflowDefinitionForAsset; describe the actual source-tree write, native deploy, and resulting frozen definition instead, and note that a pre-CL-7363 definition stays launchable as-is and only redeploys natively on its next edit.
TheGreatAxios
force-pushed
the
cl-7363-agent-builder-native
branch
from
September 2, 2026 10:56
89f86bf to
b3aa796
Compare
TheGreatAxios
marked this pull request as ready for review
September 2, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/tenants/:tenantId/agent-definitionsand every other content-mutating agent-directory route) used to self-freeze its definition through@corbits/workflow-freeze'sDefinitionFreezer, a hub-local path that bypasses the native sidecar probe.WorkflowDeployer@corbits/agent-workflow-authoring's registry already calls: write the source tree viaAssetService.populateAsset, then deploy the resulting commit throughsessionService.deployWorkflowFromSource(install -> sidecar probe -> gate -> freeze). Wired inapps/hub/src/index.tsat all four agent-directory route mounts.unavailableenvelope the native deployments route uses — no fallback to freezing.@corbits/workflow-freezedependency from@corbits/agent-directoryentirely (package.json + every import); added a source-grep regression test guarding against it creeping back.docs/AGENTS-PAGE.md's "Creating an agent" section accordingly.Links https://linear.app/abklabs/issue/CL-7363
Remaining
workflow-freezeimporters (out of scope — CL-7364 owns deletion)packages/workflow-freeze/src/index.ts(the package itself)apps/hub/src/index.ts— still importsfreezeInertWorkflowDefinitionfor the unrelated template-block freeze pathpackages/workflow-catalog/test/block-workflow-freeze.test.tspackages/workflow-catalog,apps/hubTest plan
bunx tsc --noEmit -p packages/agent-directorybunx tsc --noEmit -p apps/hubbun test packages/agent-directory packages/agent-workflow-authoring(256 pass, 21 skipped DB-gated suites — no localDATABASE_URL)Resolves CL-7363