Delete obsolete routine inference and hub-local freeze paths; correct docs (CL-7364, CL-7365) - #562
Open
TheGreatAxios wants to merge 7 commits into
Open
Delete obsolete routine inference and hub-local freeze paths; correct docs (CL-7364, CL-7365)#562TheGreatAxios wants to merge 7 commits into
TheGreatAxios wants to merge 7 commits into
Conversation
TheGreatAxios
force-pushed
the
cl-7364-cleanup
branch
from
September 2, 2026 07:44
030b04b to
41e7cac
Compare
TheGreatAxios
changed the base branch from
cl-7358-target-edit
to
cl-7371-workflow-detail
September 2, 2026 07:45
TheGreatAxios
force-pushed
the
cl-7364-cleanup
branch
from
September 2, 2026 08:53
41e7cac to
3f2daaf
Compare
TheGreatAxios
force-pushed
the
cl-7364-cleanup
branch
from
September 2, 2026 09:14
3f2daaf to
797182b
Compare
TheGreatAxios
force-pushed
the
cl-7364-cleanup
branch
2 times, most recently
from
September 2, 2026 09:53
770d681 to
8e67a7a
Compare
A create or PATCH-carried retarget now must clear the same two gates before it is persisted: resolveLaunchableDefinition must resolve the asset, and the acting principal must be authorized for workflow-definition:<id>/read — the same verb listRoutineTargets already checks per row. A denial is a typed 403 alongside the existing 400/404/409 target envelopes, on both the tenant-session and Myra's workflow-run-authenticated routine surfaces. Also routes a pre-existing catch in postRoutineEnabledNotice through reportError, since this change's diff now touches that line and check:report-error requires it.
…CL-7364) The template-block route was still self-freezing an inert workflow definition through @corbits/workflow-freeze's freezeInertWorkflowDefinition instead of going through the real install/probe/gate/freeze pipeline. It now writes its source tree and calls the same workflowDeployer.deploy the agent-authored deploy path already uses. Adds check:routine-target-inference, guarding two CL-7364 deletions from regrowing: agents[0]-derived routine targets in apps/web and packages/chat-ui, and any non-vendor read/write of the retired workflow.json path. @corbits/workflow-freeze stays: packages/agent-directory still calls DefinitionFreezer.freeze/refreeze for agent definitions, so the package and its dependents are not removed. No routine target inference, resolveCreateTarget, or ensureMyraWorkbench-as-target code was found on this branch — CL-7358 already cut that over. packages/workflow-host-actions and packages/agent-directory/src/resolve-myra-definition-id.ts (still used by Myra drafting) do not exist to delete / are still needed, respectively.
…vely (CL-7365) docs/workflow-model.md's "Behavior to delete, not retain" section now reads "Deleted in CL-7364" and describes what actually landed: routine target inference removal, the template-block route's cutover to workflowDeployer, and the check that guards both. Notes that packages/agent-directory's own DefinitionFreezer usage is a separate, not-yet-cut-over caller, so @corbits/workflow-freeze isn't documented as gone. docs/AGENTS-PAGE.md no longer describes the agent-definitions create route as writing a workflow.json file — it writes a @corbits/workflow-source codebase and freezes it, matching the retired-envelope rule everywhere else in the docs.
TheGreatAxios
force-pushed
the
cl-7364-cleanup
branch
from
September 2, 2026 11:00
8e67a7a to
e16d6fb
Compare
TheGreatAxios
marked this pull request as ready for review
September 2, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-7364, CL-7365.
Merge with cl-7363-agent-builder-native
This PR merged in
cl-7363-agent-builder-native, which cutpackages/agent-directoryover to native deploy (
WorkflowDeployer) for agent definitions — the caller this PRpreviously listed as "retained" for
@corbits/workflow-freeze. That removed the lastreal importer, so this PR now deletes the package outright instead of leaving it in
place.
Conflicts resolved:
apps/hub/src/index.ts— oneworkflowDeployer(WorkflowDeployer) instance,passed to both
packages/agent-directory's routes (cl-7363) and the template-blockdeploy path (this branch); all
@corbits/workflow-freezeimports dropped.docs/AGENTS-PAGE.md— kept cl-7363's "Creating an agent" wording (source tree →native deploy via
WorkflowDeployer→ frozen definition).bun.lock— took theirs, regenerated viabun install --lockfile-only+bun install.CL-7364 — deletions / cutovers
packages/workflow-freeze/entirely (package, tests, LICENSE,tsconfigs) —
grep -rn "workflow-freeze"after the merge showed no remainingsource importer, only the package itself, an
agent-directoryregression testguarding the cutover (
native-deploy-cutover.test.ts, kept — it now triviallypasses since the package is gone), and historical doc mentions.
apps/hub/package.json's@corbits/workflow-freezedependency,and its
tsconfig.build.jsonproject reference.packages/workflow-host-actions: confirmed absent (no tracked files).packages/agent-directory/src/definition-asset.ts'sstatusForAgentDefinitionDeployErrorwas missing the"wire_hash_mismatch"case (CL-7362) that
@corbits/agent-workflow-authoring's ownstatusForalready handles — added, matching that mapping (409).
docs/workflow-model.md's "Not yet cut over" note (agent-directory still usingDefinitionFreezer) is now stale and rewritten to describe the actual cutover.No real importer remains — nothing to list as retained.
CL-7365 — docs
Checked PRODUCT.md, ARCHITECTURE.md, IMPLEMENTATION.md, docs/GLOSSARY.md,
packages/routines/README.md,workflows/README.md, anddocs/AGENTS-PAGE.mdagainst
docs/workflow-model.md's model (source asset → native deploy →deployed definition → routine → run). All were already consistent — no
workflow.json,DefinitionFreezer, or hub-local-freeze claims remainedactive outside historical/labeled notes (e.g.
packages/evals/README.md'sCL-6439 pass narrative, left as historical).
Checks
bun run typecheck,check:routine-target-inference,check:licenses,bun run scripts/generate-tsconfig-references.ts --check(routines-toolsdrift pre-existing/unrelated, left as-is), and
bun test packages/agent-directory apps/hub/src(298 pass, 37 DB-gated skip locally) —all green.
Resolves CL-7364
Resolves CL-7365