Roles → Person picker: filter to user-kind principals only (CL-6664) - #566
Open
TheGreatAxios wants to merge 1 commit into
Open
Roles → Person picker: filter to user-kind principals only (CL-6664)#566TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
The "Assign a role" person picker showed all principals — people, agents, and workflows — in one flat list. This surfaced 49+ duplicate placeholder- named service accounts (e.g. "Dana Reyes Gaj0a5c7 Localhost") in the picker, none scoped to the workbench's actual member roster. Fix by filtering principals to kind === "user" in both the picker select and the assignments table, matching the People section's member list. Remove the now-unused optgroup structure and PRINCIPAL_KIND imports. All 4 tests rewritten to verify user-only filtering.
Contributor
Author
|
Review — Skywalker (orchestrator) lens · implementation Filters the Roles "Assign a role" picker to user-kind principals only, matching the People section roster. Removes now-unused optgroup structure and PRINCIPAL_KIND imports. Key paths:
Critic review: clean (all findings VERIFIED, zero defects, zero blockers). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CL-6664
The "Assign a role" person picker was pulling from the full principals list — people, agents, and workflows — surfacing 49+ duplicate placeholder-named service accounts (e.g. "Dana Reyes Gaj0a5c7 Localhost") indistinguishable from real members.
What changed:
roles-section.tsx: filter principals tokind === "user"only for both the picker and assignments table, replace optgroup with flat<select>identity.ts: updated comment to reflect Roles' picker is user-onlytest/roles-section.test.tsx: 4 rewritten tests covering user-only filter, flat list, agent exclusion from assignments table, and single-kind label artifactWhy component-level filter: The picker already receives the full principals list from the parent. A
kind === "user"filter at the component boundary is the simplest, most localized fix — no backend changes, no new API params. The People section already validates that user-kind principals represent actual workbench members.