Conversation
…g-LOINC-version warning Four optional, consumer-supplied publication elements ride on a LIVD catalog (publisher, publication version, LOINC version, LOINC copyright), each preserved verbatim and validated by nothing. The declared LOINC version is carried onto every annotation the catalog produces, conditionally, so a catalog declaring none keeps the key set it has today. A catalog defined with no LOINC version surfaces a value-free ASTM_LIVD_CATALOG_NO_LOINC_VERSION warning on the catalog itself and is still built: the message is a constant and the catalog is named through a structured identity field, which says positively when none was declared.
…ness record The LIVD guide section builds its catalog with the four publication elements, states that the LOINC license requires a statement of attribution and where the consumer's statement rides, and puts the two limits beside the capability: this package validates none of the metadata, and carrying an attribution is not discharging it. The changeset is minor because the change adds public values; the release-readiness record names it in the audit, enumerates the five added identifiers with the counts to match, and records the LivdWarningCode widening as its one break candidate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec:
pipeline/active/S0314-astm-13/spec.md(umbrella).A consumer who builds a LIVD catalog from a vendor publication could record the vendor rows and nothing about the publication behind them, so a mapping this library annotated was not reproducible and the attribution statement the LOINC license requires had nowhere to travel beside the mappings it applies to.
What this adds
LivdPublication: four optional publication-level elements (publisher,publicationVersion,loincVersion,loincCopyright), supplied as an optional second argument todefineLivdCatalogand readable back asLivdCatalog.publication. Each declared value is preserved verbatim; absent, empty and whitespace only are one case, no value declared.LivdAnnotation.catalogLoincVersion: the catalog's declared LOINC version, carried on every annotation that catalog produced, whatever the lookup answered. Conditional, so an annotation from a catalog declaring none keeps the key set it has today.ASTM_LIVD_CATALOG_NO_LOINC_VERSIONonLivdCatalog.warnings, raised once where the catalog is defined and never per record, withAstmLivdCatalogWarning,LivdCatalogIdentity,LIVD_CATALOG_IDENTITY_UNDECLAREDandlivdCatalogMissingLoincVersion.What it deliberately does not do
Release bookkeeping: a
minorchangeset (it adds public values), aCHANGELOG.md[Unreleased]entry, anddocumentation/release-readiness.mdupdated: the audit row, the five added identifiers in the surface enumerations with the counts to match, and the one break candidate this carries (LivdWarningCodegains a registry member, so an exhaustive switch needs one more arm).Gates:
pnpm typecheck && pnpm lint && pnpm format:check && pnpm test:coverage && pnpm build && pnpm attw && pnpm smoke && pnpm check && pnpm check:no-emdash && pnpm check:no-internal-refs && pnpm phi-scanruns green end to end (1220 passed, 4 pre-existing skips;src/terminologyat 99.03 statements, 99.19 branches). No gate config, allow-list or workflow was touched, and no suppression or skipped test was added.