S0336-shared-scripts-sweep: run both gates as thin callers of the shared reusable workflows - #59
Merged
Merged
Conversation
…red reusable workflows The em-dash and public-surface gates now delegate their plumbing (checkout, pnpm, Node) to cosyte/.github, pinned to the 40 character commit the reusable workflows were published at. The scanners stay here: this repo's own scripts/check-no-emdash.sh and scripts/check-no-internal-refs.sh are still what decides each job, and neither script changed. The check-run contexts move with the shape, from no-emdash to no-emdash / tracked-files and from no-internal-refs to no-internal-refs / public-surface, so the ruleset that requires them moves too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the reusable gate workflows published by cosyte/.github, pinned to the 40 character commit 84ecccd771cbc9c1ece003a3f8ff61415360395b (published reference workflows-2026-09-18-84ecccd771cb).
What moves: the plumbing only. Checkout, pnpm and Node now come from the shared workflow. What stays: the scanners. scripts/check-no-emdash.sh and scripts/check-no-internal-refs.sh are unchanged, still live here, and their exit status is still what decides each job. No script, no test, no fixture, no source file and no version changed.
The check-run contexts move with the shape: no-emdash becomes no-emdash / tracked-files plus no-emdash / messages, and no-internal-refs becomes no-internal-refs / public-surface. The ruleset that requires both is updated to the new strings in the same pass, because a required context nothing emits blocks every pull request.
Gate-survival probes, run locally on this commit: an untracked scratch file carrying one synthetic trigger, made visible to the scripts' own git ls-files enumeration, exits 1 through pnpm check:no-emdash and 1 through pnpm check:no-internal-refs; the clean tree exits 0 through both. Corpus green: 41 files, 777 tests. PHI scan identical at the base commit and here.
Spec: pipeline/active/S0336-shared-scripts-sweep/spec.md, child pipeline/active/S0336-shared-scripts-sweep/children/cli.md