TestValueFlow: Remove redundant test configuration, make settings const - #8776
Merged
Merged
Conversation
Collaborator
|
Can |
Collaborator
Author
Now it is. |
chrchr-github
changed the title
firewave
approved these changes
Aug 6, 2026
chrchr-github
merged commit Aug 6, 2026
baf5eaa
into
cppcheck-opensource:main
73 of 74 checks passed
chrchr-github
commented
Aug 6, 2026
| "}"; | ||
| ASSERT_EQUALS(true, testValueOfX(code, 4U, 100, ValueFlow::Value::ValueType::BUFFER_SIZE)); | ||
| ASSERT_EQUALS(true, testValueOfX(code, 4U, 100, ValueFlow::Value::ValueType::BUFFER_SIZE, &settingsCfg)); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
This seems to be the only test that actually needs the special settings, and only bsd.cfg at that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.