cpp/llvm: select LLVM 21 on Windows - #2
Closed
zhouguangyuan0718 wants to merge 1 commit into
Closed
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llvm-21pkg-config package for the Windows LLVM bridgellvm-config --host-targetABI selection unchangedContext
This is a one-commit follow-up stacked on goplus#26. LLGo xgo-dev/llgo#2334 switches its default toolchain and Windows payload to LLVM 21, while goplus#26 still requests
llvm-19; that makes the Windows demangle package fail before linking because the requested pkg-config package is absent.Merging this PR into the head branch of goplus#26 updates that PR without duplicating its Windows interop history.
Validation
go test ./...GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go test ./cpp/llvmcl/_testlibc/demangle, passed with the same three-line change before rebasing it onto the latest c, cpp: add minimal Windows interop bindings goplus/lib#26 head: https://github.com/xgo-dev/llgo/actions/runs/33163479599/job/98823273324