⚡ Bolt: Optimize bulk inserts with add_many() - #232
Conversation
Replaced individual `add` calls with `add_many` (utilizing `session.add_all()`) for `DocumentTagRecord`, `DocumentChunkRecord`, `DocumentArtifactRecord`, and `ParseRunAttemptRecord` during parse persistence. Looping through individual `.add()` calls triggers N+1 query patterns due to sequential inserts and `session.refresh()` calls for each record, significantly slowing down document parsing performance when dealing with many chunks or tags. Co-authored-by: crabcanon <3458947+crabcanon@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
💡 What: Replaced individual
addcalls withadd_many(utilizingsession.add_all()) forDocumentTagRecord,DocumentChunkRecord,DocumentArtifactRecord, andParseRunAttemptRecordduring parse persistence.🎯 Why: Looping through individual
.add()calls triggers N+1 query patterns due to sequential inserts andsession.refresh()calls for each record, significantly slowing down document parsing performance when dealing with many chunks or tags.📊 Impact: Reduces database queries from O(N) to O(1) for saving tags, chunks, artifacts, and parse run attempts, which should noticeably decrease document persistence latency for large files.
🔬 Measurement: Review the time spent saving results to the database during document parse workflows.
PR created automatically by Jules for task 14225160288368423079 started by @crabcanon