Skip to content

feat/m1-object-store-skeleton - #6

Open
mahis1067 wants to merge 5 commits into
mainfrom
week1/m1-object-store-skeleton
Open

feat/m1-object-store-skeleton#6
mahis1067 wants to merge 5 commits into
mainfrom
week1/m1-object-store-skeleton

Conversation

@mahis1067

Copy link
Copy Markdown
Collaborator

Summary

objects.py

Contains code for following ObjectStore

  • hash_object
  • write_object
  • read_object

Created the following CLI functions

  • run_hash_object
  • run_cat_file
  • register_subcommands

cli.py

Wired the CLI functions from object.py into _register_commands

tests/test_objects.py

Created the following test functions

  • test_round_trip
  • test_identical_object_same_hash
  • test_different_objects_different_hash
  • test_idempotent_write
  • test_unknown_hash_raises
  • test_hash_object_cli_print
  • test_cat_file_cli_print

Validation

  • scripts/quality-check.sh
  • Manual testing, if applicable:

Checklist

  • The change is focused and easy to review.
  • Tests were added or updated for behavior changes.
  • Documentation was updated for user-facing or setup changes.
  • No secrets, generated artifacts, or local-only files are included.

Notes for Reviewers

test_hash_object_cli_print should work for both the placeholder hash and SHA-1 when we implement it in Week 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant