Yh cyber windowed blending sampler - #53
Merged
Merged
Conversation
This was
linked to
issues
Aug 21, 2026
Closed
Closed
Coverage Report for CI Build 32797978609Coverage increased (+1.0%) to 97.822%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
KurbyDoo
requested changes
Aug 22, 2026
KurbyDoo
left a comment
Member
There was a problem hiding this comment.
overall the structure looks good, just some things to clean up function boundaries and make testing easier
Member
|
I have a fix for the script error? Could you take a look #54 |
…d pytest-mocker to project dependencies
… yh-cyber-windowed-blending-sampler
Contributor
Author
|
I've implemented all changes! |
KurbyDoo
approved these changes
Aug 23, 2026
KurbyDoo
left a comment
Member
There was a problem hiding this comment.
Right now the windows are dependent on the region which is fine for now, later we will work to make them independent of the requested region and instead based on a global coordinate space. I'll make tickets for that later
KurbyDoo
approved these changes
Aug 25, 2026
KurbyDoo
left a comment
Member
There was a problem hiding this comment.
thanks for addressing my comments, looks good to merge after this
…om/cssu/terrain-diffusion into yh-cyber-windowed-blending-sampler
Contributor
Author
|
np, thnx. once you take a look and resolve the conversations, ill squash and merge. |
KurbyDoo
reviewed
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
scripts/quality-check.shpasses locally/testcommands were run and are passing (e.g./test gpu)Checklist
Additional Comments
I think there might be something wrong with scripts/quality-check.sh for me.
This is what I got when I ran scripts/quality-check.sh