Skip to content

⚡ Bolt: Pre-compile input validation regular expressions in initialization script #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: Pre-compile input validation regular expressions in initialization script #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions scripts/init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
_git_config_loaded = False
GIT_BIN = "/usr/bin/git"

# Pre-compile regular expressions at module level to avoid re-compilation overhead during input validation
_RE_GITHUB_USER = re.compile(r"^[a-zA-Z0-9-]+$")
_RE_PROJECT_NAME = re.compile(r"^[a-zA-Z0-9_-]+$")
_RE_EMAIL = re.compile(r"^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\.[a-zA-Z0-9-.]+$")


def _load_git_config_cache():
global _git_config_loaded
Expand Down Expand Up @@ -45,7 +50,7 @@ def _get_git_config(key: str) -> str:
def _get_default_github() -> str:
# Try git config first
username = _get_git_config("github.user") or _get_git_config("user.name")
if username and re.match(r"^[a-zA-Z0-9-]+$", username):
if username and _RE_GITHUB_USER.match(username):
return username

# Try to extract from remote URL
Expand Down Expand Up @@ -80,15 +85,15 @@ def _validate_inputs(name: str, description: str, author: str, email: str, githu
if label != "description" and '"' in value:
raise UsageError(f"Invalid {label}: double quotes are not allowed.")

if not re.match(r"^[a-zA-Z0-9_-]+$", name):
if not _RE_PROJECT_NAME.match(name):
raise UsageError(
f"Invalid project name '{name}'. Only alphanumeric characters, dashes, and underscores are allowed."
)

if not re.match(r"^[a-zA-Z0-9-]+$", github):
if not _RE_GITHUB_USER.match(github):
raise UsageError(f"Invalid GitHub username '{github}'. Only alphanumeric characters and dashes are allowed.")

if not re.match(r"^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\.[a-zA-Z0-9-.]+$", email):
if not _RE_EMAIL.match(email):
raise UsageError(f"Invalid email address '{email}'.")


Expand Down