Fix QuantifierRef.sort to return the correct sort for lambda expressions - #115
Closed
msakai wants to merge 1 commit into
Closed
Fix QuantifierRef.sort to return the correct sort for lambda expressions#115msakai wants to merge 1 commit into
msakai wants to merge 1 commit into
Conversation
Contributor
|
Closing as superseded by PR #118. |
daniel-larraz
added a commit
that referenced
this pull request
Aug 12, 2026
QuantifierRef.sort() hardcoded the Boolean sort, so a lambda expression reported Bool instead of its actual function sort. Return the real sort for lambdas, and introduce FuncSortRef so that function sorts are more than an opaque SortRef. _to_sort_ref now routes function sorts to it, giving every function sort - a lambda's or an uninterpreted function's - the arity(), domain(), domain_n() and range() accessors. Those names mirror Z3Py's ArraySortRef, where lambdas have array sorts, so code inspecting a lambda's sort carries over from Z3Py. cvc5 keeps function and array sorts distinct, so is_array_sort() still reports False for them; add is_func_sort() to test for the new sort. FuncDeclRef.arity/domain/range now delegate to the sort instead of each re-deriving from getSort().getFunction*(), which is behavior-preserving: every FuncDeclRef is built from a function sort. This supersedes #115. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.