fix(security): update minimatch to pull a patched brace-expansion - #246
Merged
Conversation
minimatch@10.2.6 (still inside the ^10.2.2/^10.2.5 ranges glob and typedoc already declare) requires brace-expansion@^5.0.8, which lets pnpm resolve brace-expansion@5.0.9 — the release that patches GHSA-mh99-v99m-4gvg and GHSA-rgw5-rvv9-x895. No override needed: this is a plain `pnpm update minimatch -r` within dependents' own declared ranges, not a forced resolution. `pnpm audit`: 2 high -> 0. Dependabot alerts stayed at 0 open throughout. No override was added or widened.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #245. That fix bounded the misconfigured overrides but left
brace-expansion@5.0.7in place viaminimatch@10.2.5(a direct dependency ofglob@13.0.6/typedoc@0.28.20, unreachable through any override) — 2 high advisories (GHSA-mh99-v99m-4gvg, GHSA-rgw5-rvv9-x895), patched atbrace-expansion@5.0.9.No override was added. Checked whether a parent bump reaches the fix before reaching for an override, per the constraint that an override is the fallback, not the first move:
globandtypedocare already at their latest releases (13.0.6,0.28.20) — nothing newer to bump there.minimatch@10.2.6exists and is still inside the^10.2.2/^10.2.5ranges glob/typedoc already declare, and it requiresbrace-expansion@^5.0.8(vs10.2.5's^5.0.5).pnpm update minimatch -r(a plain in-range update, not a forced/pinned resolution) picked up10.2.6, and pnpm resolvedbrace-expansion@^5.0.8to the highest satisfying release,5.0.9— the patched one.So this closes both advisories with a parent bump alone.
pnpm-workspace.yamlis untouched; the diff is lockfile-only.Advisories
pnpm audit: 2 high → 0gh api repos/cyberuni/path-equal/dependabot/alerts(open count): 0 → 0 (unchanged, already 0)Release
Dev-tree only (
path-equalships no runtime dependencies), nothing shipped changes → no changeset, no version bump.Test plan
pnpm install --frozen-lockfile— cleanpnpm verify(biome + build + typecheck + coverage + depcheck + size) — all greenpnpm audit— 0 vulnerabilities