Version Packages - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
path-equal@1.2.8
Patch Changes
e2cb9c7: Serve CJS type declarations to CJS consumers.
The
exportsmap carried one top-leveltypespointing at./esm/index.d.ts, and norequirecondition. A CommonJS consumer resolving undernode16/nodenextwas therefore handed the ESM declarations and told the package was ESM, failing withTS1479: the referenced file is an ECMAScript module and cannot be imported with 'require'.Nothing was wrong with the emitted code —
cjs/package.jsonalready declares{"type":"commonjs"}andcjs/index.d.tsalready shipped. The manifest simply never pointed at it.moduleResolution: "node"ignoresexportsmaps entirely, which is why this went unnoticed.exportsnow resolvesrequireandimportseparately, each with the declarations that match its format, and the top-leveltypesagrees withmaininstead of contradicting it.