test(e2e): wait for app readiness inside the navigation helpers

[d-oit]

Why

Follow-on to #813 (plans/149 §5.2). That PR gave the shell a real post-hydration signal (data-app-ready) and used it in the three Ctrl+K specs. This one closes the rest of the class — measured, not guessed.

Measured exposure

Auditing all 24 specs showed the risk was concentrated in the shared navigation path, not spread across specs:

Pattern	Specs	Handling
Navigate via navClick / openNavIfHidden	22	covered by a wait inside the helper
Set viewport then goto, click "Open menu" directly	responsive.spec.ts	wait after each of its seven goto calls
goto then click a server-rendered panel control	right-panel.spec.ts	wait in beforeEach
No interactions	contrast.spec.ts	n/a

So openNavIfHidden now waits for data-app-ready before clicking, which covers crud-workflow, home, timeline, progressive-disclosure and accessibility (all have navClick(...) as their first action) without touching them.

One trap worth recording: responsive.spec.ts sets the viewport before navigating, so a beforeEach wait would run against about:blank and time out — the wait has to follow each goto.

Verification

Check	Result
Full sweep (596 tests, all four projects)	592 passed, 4 skipped, 0 failed, no flaky (6.4 m)
pnpm run lint, pnpm run typecheck	clean
./scripts/quality_gate.sh, pnpm run build	✓ green

No assertions were loosened; the only behavioural change is that helpers wait for the shell to mount before clicking.

Plan: plans/149-nightly-full-viewport-e2e-2026-09-24.md §5.2.

---

📝 Summary by GitNexus

Summary

This appears to be a small, test-focused update concentrated in end-to-end navigation helpers and related responsive and right-panel coverage. Its reach is shallow, with no traced execution flows or elevated file-risk findings.

🟢 LOW blast radius. An end-to-end test change centered on openNavIfHidden and navClick in e2e/helpers/navigation.ts, reaching one direct dependent.

The change is concentrated in the E2E test area, with helper updates in e2e/helpers/navigation.ts and related coverage in e2e/responsive.spec.ts and e2e/right-panel.spec.ts. The accompanying plan updates are in plans/149-nightly-full-viewport-e2e-2026-09-24.md, including Plan 149. Nightly E2E Sweep Covers Every Viewport (2026-09-24) and 5. Follow-ups.

Review openNavIfHidden and navClick first, then verify that the responsive and right-panel specifications continue to use the navigation helpers as intended.

Added by GitNexus for PR #815. Edit freely — this block is replaced on the next review, everything above it is left untouched.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
do-knowledge-studio	Ready	Preview, v0	Sep 24, 2026 1:09pm UTC

[github-actions]

Blocked merge diagnosis — blocked
⏳ Check run(s) still in progress: ["Codacy Static Code Analysis","Trivy Filesystem Security Scan","Infrastructure as Code Security","Shell Script Security Analysis","Secret Detection","labeler","Diagnose Blocked Merge State","Detect Changes","commitlint","Analyze (actions)","Analyze (javascript-typescript)"]

[nexuscheck]

GitNexus Review · PR #815

GitNexus reviewed 4 changed files.

🤖 Agent context — 4 symbols · 4 files

Summary

This appears to be a small, test-focused update concentrated in end-to-end navigation helpers and related responsive and right-panel coverage. Its reach is shallow, with no traced execution flows or elevated file-risk findings.

🟢 LOW blast radius. An end-to-end test change centered on openNavIfHidden and navClick in e2e/helpers/navigation.ts, reaching one direct dependent.

The change is concentrated in the E2E test area, with helper updates in e2e/helpers/navigation.ts and related coverage in e2e/responsive.spec.ts and e2e/right-panel.spec.ts. The accompanying plan updates are in plans/149-nightly-full-viewport-e2e-2026-09-24.md, including Plan 149. Nightly E2E Sweep Covers Every Viewport (2026-09-24) and 5. Follow-ups.

Review openNavIfHidden and navClick first, then verify that the responsive and right-panel specifications continue to use the navigation helpers as intended.

🟢 LOW blast radius — this change reaches 1 downstream symbol across 1 module.

Blast Level	Dependents	Modules	Files
🟢 LOW	1	1	4

What changed

Symbol Changes (4)

Kind	Symbol	Location
Function	openNavIfHidden	e2e/helpers/navigation.ts:11
Function	navClick	e2e/helpers/navigation.ts:30
Section	Plan 149 — Nightly E2E Sweep Covers Every Viewport (2026-09-24)	plans/149-nightly-full-viewport-e2e-2026-09-24.md:1
Section	5. Follow-ups	plans/149-nightly-full-viewport-e2e-2026-09-24.md:183

Changed Files (4)

File	Status
e2e/helpers/navigation.ts	🟡 modified
e2e/responsive.spec.ts	🟡 modified
e2e/right-panel.spec.ts	🟡 modified
plans/149-nightly-full-viewport-e2e-2026-09-24.md	🟡 modified

What it affects

Architecture Impact

Module	Hits	Direct
Cluster_9	3	🟢

Blast Radius

Depth	Count
d1 (direct)	1
d2 (indirect)	0
d3 (transitive)	0

Direct dependents (d1)

• e2e/helpers/editor.ts:10 · createNewEntity

Full detail lives in the GitNexus check run for this commit.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}