Skip to content

fix(e2e): stabilize semantic search fallback - #822

Merged
d-oit merged 1 commit into
mainfrom
feat/stabilize-nightly-e2e
Sep 25, 2026
Merged

d-oit merged 1 commit into
mainfrom
feat/stabilize-nightly-e2e

Conversation

@d-oit

@d-oit d-oit commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

Stabilize the semantic-search fallback E2E test: block the app service worker so Playwright routing intercepts model requests, fulfill model/CDN requests with deterministic 404s, and assert the visible lexical TRIZ result. Set a 10s assertion timeout inside a 15s per-test timeout. No production semantic-search or workflow code changed.

Related context: #751 (this PR only changes test reliability).

Type of change

  • fix: isolated E2E reliability issue
  • No breaking change

Testing

  • env -u NO_COLOR pnpm exec playwright test e2e/semantic-search.spec.ts --project=chromium --repeat-each=3 --retries=0 — 9 passed (29.8s).
  • env -u NO_COLOR pnpm exec playwright test --retries=0 --grep-invert="probe: console timeline" — 600 passed, 4 skipped (8.8m), all four projects.
  • env -u NO_COLOR ./scripts/quality_gate.sh — passed.
  • env -u NO_COLOR pnpm run build — passed.

The untracked e2e/zz-probe.spec.ts remains untouched and is not part of this PR. A pre-existing React hydration mismatch in HomeView motion styles is documented in plans/151; it is not suppressed by this change. Scheduled run 36112610311 confirmed the nightly E2E job ran on its pre-change main revision; this branch's PR checks are the validation for this patch.

Risk

Low. Test-only behavior and planning evidence; no runtime application change.


📝 Summary by GitNexus

Summary

This appears to be a small, self-contained end-to-end test stabilization change, with accompanying planning documentation and no detected downstream reach.

🟢 LOW blast radius. An end-to-end semantic-search test change in e2e/semantic-search.spec.ts with no graph-detected dependents or affected execution flows.

The code change is concentrated in e2e/semantic-search.spec.ts, while the remaining changed symbols are documentation sections in plans/149-nightly-full-viewport-e2e-2026-09-24.md and plans/151-quality-gate-lint-cache-and-nightly-guard-2026-09-24.md. Review the semantic-search test behavior first, then verify that the follow-up documentation remains aligned with the test scope.

No high or critical risk files, cross-repo consumers, or affected flows were detected.

Added by GitNexus for PR #822. Edit freely — this block is replaced on the next review, everything above it is left untouched.

@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
do-knowledge-studio Ready Ready Preview, v0 Sep 25, 2026 10:14am UTC

@github-actions github-actions Bot added documentation Documentation improvements config tests Related to automated/manual tests labels Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Blocked merge diagnosis — blocked
⏳ Check run(s) still in progress: ["shellcheck","Dependency Verify","Quality Gate","Unit Tests","Codacy Static Code Analysis","labeler","Diagnose Blocked Merge State","Infrastructure as Code Security","Shell Script Security Analysis","Secret Detection","Trivy Filesystem Security Scan","commitlint","Analyze (javascript-typescript)","Analyze (actions)"]

@nexuscheck

nexuscheck Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor
Akon Labs

GitNexus Review · PR #822

GitNexus reviewed 3 changed files.

🤖 Agent context — 4 symbols · 3 files

Summary

This appears to be a small, self-contained end-to-end test stabilization change, with accompanying planning documentation and no detected downstream reach.

🟢 LOW blast radius. An end-to-end semantic-search test change in e2e/semantic-search.spec.ts with no graph-detected dependents or affected execution flows.

The code change is concentrated in e2e/semantic-search.spec.ts, while the remaining changed symbols are documentation sections in plans/149-nightly-full-viewport-e2e-2026-09-24.md and plans/151-quality-gate-lint-cache-and-nightly-guard-2026-09-24.md. Review the semantic-search test behavior first, then verify that the follow-up documentation remains aligned with the test scope.

No high or critical risk files, cross-repo consumers, or affected flows were detected.

🟢 LOW blast radius — no downstream dependents were found in the code graph.

Blast Level Dependents Modules Files
🟢 LOW 0 0 3

What changed

Symbol Changes (4)
Kind Symbol Location
Section Plan 149 — Nightly E2E Sweep Covers Every Viewport (2026-09-24) plans/149-nightly-full-viewport-e2e-2026-09-24.md:1
Section 5. Follow-ups plans/149-nightly-full-viewport-e2e-2026-09-24.md:183
Section Plan 151 — Quality-Gate Lint-Cache Fallback + Nightly Scope Guard (2026-09-24) plans/151-quality-gate-lint-cache-and-nightly-guard-2026-09-24.md:1
Section 5. Follow-ups plans/151-quality-gate-lint-cache-and-nightly-guard-2026-09-24.md:113
Changed Files (3)
File Status
e2e/semantic-search.spec.ts 🟡 modified
plans/149-nightly-full-viewport-e2e-2026-09-24.md 🟡 modified
plans/151-quality-gate-lint-cache-and-nightly-guard-2026-09-24.md 🟡 modified

Full detail lives in the GitNexus check run for this commit.

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@d-oit
d-oit merged commit 50cc97f into main Sep 25, 2026
25 checks passed
@d-oit
d-oit deleted the feat/stabilize-nightly-e2e branch September 25, 2026 11:05

This branch was successfully deployed

1 active deployment
Preview — cf7d74d9 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config documentation Documentation improvements tests Related to automated/manual tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants