feat(import): SQL Server connections from DBeaver (refs #516) - #630
Merged
Merged
Conversation
The provider and driver ids come from DBeaver's own plugin.xml: "sqlserver" (microsoft, azure, jtds, babelfish) and the older "mssql", which also carries Sybase ASE drivers; those are reported as Sybase rather than imported as SQL Server. A named instance comes from the host (server\INSTANCE) or the JDBC URL, dropping the port for the SQL Browser; the encryption from the URL or the driver's encrypt property (Microsoft's encrypt=false still encrypts the login: our "off"), or jTDS's ssl.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #516 — the DBeaver half; Navicat still needs a real
.ncxexport to measure its ConnType for SQL Server, so the issue stays open.plugins/org.jkiss.dbeaver.ext.mssql/plugin.xml: providersqlserver(driversmicrosoft,azure,jtds,babelfish— all TDS) and the oldermssql. The old provider also carries Sybase ASE drivers (sybase_jtds,sybase_jconn,sypase_jconn): those are reported as skipped with reason "Sybase", never imported as SQL Server.server\INSTANCE) or the JDBC URL (instanceName=, jTDSinstance=); an instance drops the port, since our driver takes one or the other and the SQL Browser finds it.encryptionfield: Microsoftencrypt=true/mandatory→require,strict→strict,false/optional→off(it still encrypts the login); jTDSssl=require|authenticate|request|off.encryptproperty, instance from the host, jTDS URL, Sybase skipped, Oracle still unsupported (Navicat fixture). Manual note updated.Note:
driverFornormalizes spaces away, so a NavicatConnTypespelled "SQL Server"/"SQLSERVER" would already map; that is to be confirmed with a real export before closing #516.