fix(grid): the new-rows bar no longer covers the row being typed (closes #633) - #634
Merged
Merged
Conversation
#633) The pending-rows bar floated over the bottom of the grid like the marked-rows bar, and the new rows are edited exactly there: it covered the cell in the Nuevas filas section. It now takes its own strip under the grid. The marked-rows bar keeps floating: it is hidden while there are new rows, so it never meets them.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #633.
The pending-rows bar (
PendingRowsBar, #517) shared the floating.row-action-bar(absolute, over the bottom of the grid), and new rows are typed in the Nuevas filas section right at that bottom, so it covered the cell being edited (user's screenshot). It now carries.row-action-bar-docked(static, centered, its own strip under the grid). The marked-rows bar keeps floating: it is hidden while there are new rows (pending.inserts.length === 0), so it never meets them.Style guard and component tests pass (53 files). Not yet looked at in the running app.