Fix connection parameter reference - #471
Conversation
43b7326 to
9c5eaec
Compare
There was a problem hiding this comment.
Verdict: 1 Low
Documentation-only PR to CONNECTION_PARAMETERS.md; the substantive behavioral claims (error sentinels for WithTransport/tokenCache, clientId alias, custom-authenticator rejection, client-result conf case-insensitivity/clamp/strip semantics, port-required-in-DSN) all check out against connector.go, kernel_config.go, config.go, and databricks_kernel.h. One low note: two numeric defaults in the new table are kernel-side and not verifiable from this repo.
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
9c5eaec to
5c4b8e6
Compare
There was a problem hiding this comment.
Verdict: 1 Nit
Looks good — accurate documentation-only PR. I verified the key behavioral claims against the driver (WithTransport error sentinel, WithTokenCache/DSN tokenCache divergence, the 256 clamp-with-warning, client-result conf keys, and warehouseId/?o= routing precedence) and they all match the implementation. One minor legend-consistency nit noted inline about the tokenCache Thrift ⚠️ marker.
Other findings
- ⚪ Nit — The
tokenCacheDSN row marks the Thrift column⚠️, but the cell text describes a split behavior:tokenCache=trueis rejected on Thrift withErrRequiresKernelBackend(an❌-style outcome per the legend), whiletokenCache=falseis an accepted no-op (a⚠️-style outcome). The legend reserves❌for "rejected at connect" and⚠️for "accepted but not fully honored," and the new fixed-value note added at the top only covers the kernel column's port/scheme. Neither single symbol cleanly captures the true-rejected / false-inert split. The cell prose does explain it, so this is a minor presentation nit — consider a footnote clarifying that the⚠️here means "conditionally rejected" rather than "inert."
Corrects CONNECTION_PARAMETERS.md so DSN and connector-option behavior is distinguished and the Thrift/kernel support matrix matches the implementation. It also documents the kernel client-result configuration surface and fixes the misleading Cloud Fetch guidance. Validation: git diff --check.