Skip to content

Fix connection parameter reference - #471

Merged
vuanhphung merged 1 commit into
mainfrom
vu-phung/fix-connection-parameters-reference
Sep 5, 2026
Merged

Fix connection parameter reference#471
vuanhphung merged 1 commit into
mainfrom
vu-phung/fix-connection-parameters-reference

Conversation

@vuanhphung

Copy link
Copy Markdown
Collaborator

Corrects CONNECTION_PARAMETERS.md so DSN and connector-option behavior is distinguished and the Thrift/kernel support matrix matches the implementation. It also documents the kernel client-result configuration surface and fixes the misleading Cloud Fetch guidance. Validation: git diff --check.

@vuanhphung
vuanhphung force-pushed the vu-phung/fix-connection-parameters-reference branch from 43b7326 to 9c5eaec Compare September 4, 2026 23:09

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: 1 Low

Documentation-only PR to CONNECTION_PARAMETERS.md; the substantive behavioral claims (error sentinels for WithTransport/tokenCache, clientId alias, custom-authenticator rejection, client-result conf case-insensitivity/clamp/strip semantics, port-required-in-DSN) all check out against connector.go, kernel_config.go, config.go, and databricks_kernel.h. One low note: two numeric defaults in the new table are kernel-side and not verifiable from this repo.

Comment thread CONNECTION_PARAMETERS.md
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
@vuanhphung
vuanhphung force-pushed the vu-phung/fix-connection-parameters-reference branch from 9c5eaec to 5c4b8e6 Compare September 5, 2026 00:53

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: 1 Nit

Looks good — accurate documentation-only PR. I verified the key behavioral claims against the driver (WithTransport error sentinel, WithTokenCache/DSN tokenCache divergence, the 256 clamp-with-warning, client-result conf keys, and warehouseId/?o= routing precedence) and they all match the implementation. One minor legend-consistency nit noted inline about the tokenCache Thrift ⚠️ marker.

Other findings

  • ⚪ Nit — The tokenCache DSN row marks the Thrift column ⚠️, but the cell text describes a split behavior: tokenCache=true is rejected on Thrift with ErrRequiresKernelBackend (an -style outcome per the legend), while tokenCache=false is an accepted no-op (a ⚠️-style outcome). The legend reserves for "rejected at connect" and ⚠️ for "accepted but not fully honored," and the new fixed-value note added at the top only covers the kernel column's port/scheme. Neither single symbol cleanly captures the true-rejected / false-inert split. The cell prose does explain it, so this is a minor presentation nit — consider a footnote clarifying that the ⚠️ here means "conditionally rejected" rather than "inert."

@vuanhphung
vuanhphung enabled auto-merge September 5, 2026 00:59
@vuanhphung
vuanhphung added this pull request to the merge queue Sep 5, 2026
Merged via the queue into main with commit f753055 Sep 5, 2026
12 of 13 checks passed
@vuanhphung
vuanhphung deleted the vu-phung/fix-connection-parameters-reference branch September 5, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant