Fix provisional node generation logic - #2174
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an optional output directory parameter for provisional node generation, handles missing Spanner dependencies gracefully, adds gcloud credential support, and updates download scripts and manifest configurations. The review feedback highlights a critical safety issue in download.sh where empty variables could lead to unintended deletions, suggests adding a timeout to the gcloud subprocess call to prevent hangs, and proposes optimizing the Spanner query to avoid an unnecessary table join.
rohitkumarbhagat
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently check the Node table to find missing nodes but this logic breaks since the import tool existence check also looks for typeOf properties in the Edge table. Once the provisional nodes are generated, the corresponding typeOf Edges are deleted by the following runs and never generated again causing import validation errors from the import tool. This PR checks the Edge table to generate provisional nodes.
Also, updated the manifest so generated provisional nodes are copied to GCS but not included in the current run causing a validation failure for a manual intervention to copy the generated nodes to be copied to the Schema repo.