Skip to content

Fix provisional node generation logic - #2174

Merged
vish-cs merged 1 commit into
datacommonsorg:masterfrom
vish-cs:schema
Aug 24, 2026
Merged

Fix provisional node generation logic#2174
vish-cs merged 1 commit into
datacommonsorg:masterfrom
vish-cs:schema

Conversation

@vish-cs

@vish-cs vish-cs commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

We currently check the Node table to find missing nodes but this logic breaks since the import tool existence check also looks for typeOf properties in the Edge table. Once the provisional nodes are generated, the corresponding typeOf Edges are deleted by the following runs and never generated again causing import validation errors from the import tool. This PR checks the Edge table to generate provisional nodes.

Also, updated the manifest so generated provisional nodes are copied to GCS but not included in the current run causing a validation failure for a manual intervention to copy the generated nodes to be copied to the Schema repo.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an optional output directory parameter for provisional node generation, handles missing Spanner dependencies gracefully, adds gcloud credential support, and updates download scripts and manifest configurations. The review feedback highlights a critical safety issue in download.sh where empty variables could lead to unintended deletions, suggests adding a timeout to the gcloud subprocess call to prevent hangs, and proposes optimizing the Spanner query to avoid an unnecessary table join.

Comment thread scripts/entities/download.sh Outdated
Comment thread import-automation/executor/scripts/generate_provisional_nodes.py Outdated
Comment thread import-automation/executor/scripts/generate_provisional_nodes.py Outdated
Comment thread import-automation/executor/scripts/generate_provisional_nodes_test.py Outdated
Comment thread import-automation/executor/scripts/generate_provisional_nodes.py Outdated
Comment thread scripts/entities/download.sh
@vish-cs
vish-cs merged commit 32bf95c into datacommonsorg:master Aug 24, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants